From: "stanley.miao" <stanley.miao@windriver.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, davem@davemloft.net,
netdev@vger.kernel.org, steve.glendinning@smsc.com
Subject: Re: [PATCH 7/8] arm: convert omap ldp platform to use smsc911x
Date: Sat, 24 Jan 2009 12:14:18 +0800 [thread overview]
Message-ID: <1232770458.18235.1.camel@localhost> (raw)
In-Reply-To: <20090122105810.GD32153@n2100.arm.linux.org.uk>
On Thu, 2009-01-22 at 10:58 +0000, Russell King - ARM Linux wrote:
> On Wed, Jan 21, 2009 at 11:06:09AM +0800, Stanley.Miao wrote:
> > - ldp_smc911x_resources[0].start = cs_mem_base + 0x0;
> > - ldp_smc911x_resources[0].end = cs_mem_base + 0xf;
> > + ldp_smsc911x_resources[0].start = cs_mem_base + 0x0;
> > + ldp_smsc911x_resources[0].end = cs_mem_base + 0x100;
>
> This doesn't look right - 'end' is inclusive not exclusive. So this
> reserves 257 bytes, not 256 bytes.
Thanks for the review, correct it.
Stanley.
next prev parent reply other threads:[~2009-01-24 4:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 13:28 [PATCH REPOST 0/6] convert arm platforms to smsc911x Steve Glendinning
2009-01-20 13:28 ` [PATCH 1/6] smsc911x: add support for platform-specific irq flags Steve Glendinning
2009-01-20 13:28 ` [PATCH 2/6] smsc911x: register isr as IRQF_SHARED Steve Glendinning
2009-01-20 13:28 ` [PATCH 3/6] arm: convert pcm037 platform to use smsc911x Steve Glendinning
2009-01-20 13:28 ` [PATCH 4/6] arm: convert realview " Steve Glendinning
2009-01-20 13:28 ` [PATCH 5/6] arm: update pcm037 defconfig " Steve Glendinning
2009-01-20 13:28 ` [PATCH 6/6] arm: update realview defconfigs " Steve Glendinning
2009-01-20 13:44 ` [PATCH 4/6] arm: convert realview platform " Catalin Marinas
2009-01-20 15:29 ` [PATCH 3/6] arm: convert pcm037 " Sascha Hauer
2009-01-20 17:13 ` David Miller
2009-01-21 10:58 ` Mark Brown
2009-01-21 14:38 ` Sascha Hauer
2009-01-20 14:55 ` [PATCH 1/6] smsc911x: add support for platform-specific irq flags Ben Dooks
2009-01-21 15:54 ` Steve.Glendinning
2009-01-26 1:45 ` David Miller
2009-01-26 8:45 ` Steve.Glendinning
2009-01-21 3:06 ` [PATCH 7/8] arm: convert omap ldp platform to use smsc911x Stanley.Miao
2009-01-21 3:06 ` [PATCH 8/8] arm: update omap_ldp defconfig " Stanley.Miao
2009-01-22 10:58 ` [PATCH 7/8] arm: convert omap ldp platform " Russell King - ARM Linux
2009-01-24 4:14 ` stanley.miao [this message]
2009-01-23 17:07 ` Steve.Glendinning
2009-01-24 4:16 ` stanley.miao
2009-01-24 3:38 ` [PATCHv2 " Stanley.Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232770458.18235.1.camel@localhost \
--to=stanley.miao@windriver.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.