All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Vroon <tony@linx.net>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linux-wireless@vger.kernel.org,
	"Diego E. 'Flameeyes' Pettenò" <flameeyes@gmail.com>
Subject: [PATCH] CRDA 0.1.0: Fix building with --as-needed
Date: Sat, 24 Jan 2009 19:54:55 +0000	[thread overview]
Message-ID: <1232826895.19384.3.camel@localhost> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 218 bytes --]

It seems mails from Flameeyes just do not make it through to
linux-wireless, so there it is. Please apply this and consider releasing
1.0.1 (without a v in the tarball name, if at all possible).

Thanks,
Tony V.

[-- Attachment #1.2: Forwarded message - [PATCH] Fix building with --as-needed. --]
[-- Type: message/rfc822, Size: 3761 bytes --]

From: "Diego Elio 'Flameeyes' Pettenò" <flameeyes@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: "Tony Vroon" <tony@linx.net>, "Diego E. 'Flameeyes' Pettenò" <flameeyes@gmail.com>
Subject: [PATCH] Fix building with --as-needed.
Date: Sat, 24 Jan 2009 17:50:31 +0100
Message-ID: <1232815831-6437-1-git-send-email-flameeyes@gmail.com>

From: Diego E. 'Flameeyes' Pettenò <flameeyes@gmail.com>

For --as-needed to work (and for traditional ld too) the libraries should
always be passed _after_ the object files, move them so that they are
picked up properly.

Also rename LIBS to NLLIBS to avoid confusion between LIBS/LDLIBS.
---
 Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index a07fbcf..aaa9ca6 100644
--- a/Makefile
+++ b/Makefile
@@ -48,11 +48,11 @@ endif
 
 ifeq ($(NL2FOUND),Y)
 CFLAGS += -DCONFIG_LIBNL20
-LIBS += -lnl-genl
+NLLIBS += -lnl-genl
 NLLIBNAME = libnl-2.0
 endif
 
-LIBS += `pkg-config --libs $(NLLIBNAME)`
+NLLIBS += `pkg-config --libs $(NLLIBNAME)`
 CFLAGS += `pkg-config --cflags $(NLLIBNAME)`
 
 ifeq ($(V),1)
@@ -85,7 +85,7 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
 
 crda: reglib.o crda.o
 	$(NQ) '  LD  ' $@
-	$(Q)$(CC) $(CFLAGS) $(LDFLAGS) $(LIBS) -o $@ $^ $(LDLIBS)
+	$(Q)$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(NLLIBS)
 
 regdbdump: reglib.o regdbdump.o print-regdom.o
 	$(NQ) '  LD  ' $@
-- 
1.6.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

             reply	other threads:[~2009-01-24 19:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-24 19:54 Tony Vroon [this message]
2009-01-24 20:40 ` [PATCH] CRDA 0.1.0: Fix building with --as-needed Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1232826895.19384.3.camel@localhost \
    --to=tony@linx.net \
    --cc=flameeyes@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.