Re: [PATCH 1/2] cris: introduce asm/swab.h

[Harvey Harrison <harvey.harrison@gmail.com>]

On Sat, 2009-01-24 at 17:40 +0530, Jaswinder Singh Rajput wrote:
> On Wed, Jan 14, 2009 at 8:56 AM, Harvey Harrison
> <harvey.harrison@gmail.com> wrote:
> > Adjust the arch overrides to the new names as well.
> >
> > --- /dev/null
> > +++ b/arch/cris/include/arch-v10/arch/swab.h
> > @@ -0,0 +1,30 @@
> > +#ifndef _CRIS_ARCH_SWAB_H
> > +#define _CRIS_ARCH_SWAB_H
> > +
> > +#include <asm/types.h>
> 
> Please replace #include <asm/types.h> with #include <linux/types.h>
> otherwise you will get following 'make headers_check' warnings:
>   usr/include/asm/swab.h:4: include of <linux/types.h> is preferred
> over <asm/types.h>
>   usr/include/asm/swab.h:14: found __[us]{8,16,32,64} type without
> #include <linux/types.h>
> 

1) I sent this patch bypassing the arch maintainer, so I made it as
simple as possible, just moved the byteorder.h's and changed the
names of the arch-overrides.

2) If you'd care to check, this file is not exported to userspace, so
I can't possible trigger that warning.

3) It's already in Linus' tree, so it's a bit hard for me to change it
now ;-)

Harvey