From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LRVP6-0008Sg-2O for mharc-grub-devel@gnu.org; Mon, 26 Jan 2009 12:37:44 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRVP3-0008Qg-Sc for grub-devel@gnu.org; Mon, 26 Jan 2009 12:37:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRVP2-0008PI-0k for grub-devel@gnu.org; Mon, 26 Jan 2009 12:37:41 -0500 Received: from [199.232.76.173] (port=36402 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRVP1-0008P9-Jn for grub-devel@gnu.org; Mon, 26 Jan 2009 12:37:39 -0500 Received: from mx20.gnu.org ([199.232.41.8]:52937) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LRVOy-0008Qq-3U for grub-devel@gnu.org; Mon, 26 Jan 2009 12:37:36 -0500 Received: from c60.cesmail.net ([216.154.195.49]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LRJIy-0003Cm-5j for grub-devel@gnu.org; Sun, 25 Jan 2009 23:42:36 -0500 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 25 Jan 2009 23:41:51 -0500 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 83E5B34C6D for ; Sun, 25 Jan 2009 23:56:13 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <49799320.1000300@impulze.org> References: <49771040.7010509@impulze.org> <1232559057.17462.2.camel@dv> <49799320.1000300@impulze.org> Content-Type: text/plain Date: Sun, 25 Jan 2009 23:41:49 -0500 Message-Id: <1232944909.1604.18.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 (2.24.3-1.fc10) Content-Transfer-Encoding: 7bit X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2009 17:37:42 -0000 On Fri, 2009-01-23 at 10:51 +0100, Daniel Mierswa wrote: > Am 01/21/09 18:30, Pavel Roskin schrieb: > > The patch looks good to me. I would split changes to commands/search.c > > into a separate commit. > > > > Please provide ChangeLog entries for the patches. > > > I will comply. Thanks for your quick response. I'll appreciate if you write your Changelog entries according to the GNU coding standards. In particular, please don't abbreviate function names. > 2009-01-23 Daniel Mierswa > * commands/search.c: caseless UUID comparing We have a very similar function search_fs_uuid() in disk/fs_uuid.c, and it still uses grub_strcmp(). Should it be using grub_strcasecmp() as well? Can we export that function to reuse it in commands/search.c? -- Regards, Pavel Roskin