From: Peter Zijlstra <peterz@infradead.org>
To: Louis.Rilling@kerlabs.com
Cc: Joel Becker <Joel.Becker@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, cluster-devel@redhat.com,
swhiteho <swhiteho@redhat.com>
Subject: Re: [PATCH] configfs: Silence lockdep on mkdir(), rmdir() and configfs_depend_item()
Date: Mon, 26 Jan 2009 14:41:23 +0100 [thread overview]
Message-ID: <1232977283.4863.79.camel@laptop> (raw)
In-Reply-To: <20090126132453.GD7532@hawkmoon.kerlabs.com>
On Mon, 2009-01-26 at 14:24 +0100, Louis Rilling wrote:
> However configfs_rmdir() and configfs_mkdir() (recursively) lock inodes because
> this is how the VFS works when removing/adding entries under a directory which
> has already lived in the dcache.
Ok, so then I'm not understanding things correctly.
Its not a locking correctness thing, but simply not being able to do it
from the vfs calls because those assume locks held?
Can't you simply punt the work to a worklet once you've created/removed
the non-default group, which can be done from within the vfs callback ?
next prev parent reply other threads:[~2009-01-26 13:41 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 14:20 [Cluster-devel] configfs, dlm_controld & lockdep Steven Whitehouse
2008-12-11 14:20 ` Steven Whitehouse
2008-12-11 14:44 ` Louis Rilling
2008-12-11 17:34 ` [Cluster-devel] " Joel Becker
2008-12-11 17:34 ` Joel Becker
2008-12-12 10:06 ` Louis Rilling
2008-12-12 15:29 ` [PATCH] configfs: Silence lockdep on mkdir(), rmdir() and configfs_depend_item() Louis Rilling
2008-12-17 21:40 ` [Cluster-devel] " Andrew Morton
2008-12-17 21:40 ` Andrew Morton
2008-12-17 22:03 ` [Cluster-devel] " Joel Becker
2008-12-17 22:03 ` Joel Becker
2008-12-17 22:09 ` [Cluster-devel] " Andrew Morton
2008-12-17 22:09 ` Andrew Morton
2008-12-18 7:26 ` Peter Zijlstra
2008-12-18 9:27 ` [Cluster-devel] " Joel Becker
2008-12-18 9:27 ` Joel Becker
2008-12-18 11:15 ` Louis Rilling
2008-12-18 18:00 ` Make lockdep happy with configfs Louis Rilling
2009-01-26 11:51 ` Louis Rilling
2009-01-28 3:44 ` [Cluster-devel] " Joel Becker
2009-01-28 3:44 ` Joel Becker
2008-12-18 18:00 ` [PATCH 1/2] configfs: Silence lockdep on mkdir() and rmdir() Louis Rilling
2009-01-28 3:55 ` [Cluster-devel] " Joel Becker
2009-01-28 3:55 ` Joel Becker
2009-01-28 10:38 ` Louis Rilling
2008-12-18 18:00 ` [PATCH 2/2] configfs: Rework configfs_depend_item() locking and make lockdep happy Louis Rilling
2009-01-28 4:13 ` [Cluster-devel] " Joel Becker
2009-01-28 4:13 ` Joel Becker
2009-01-28 10:32 ` Louis Rilling
2008-12-18 11:26 ` [Cluster-devel] Re: [PATCH] configfs: Silence lockdep on mkdir(), rmdir() and configfs_depend_item() Steven Whitehouse
2008-12-18 11:26 ` Steven Whitehouse
2008-12-18 11:48 ` Louis Rilling
2008-12-18 11:56 ` Peter Zijlstra
2008-12-18 12:28 ` Peter Zijlstra
2008-12-18 22:58 ` [Cluster-devel] " Joel Becker
2008-12-18 22:58 ` Joel Becker
2008-12-19 10:29 ` Louis Rilling
2009-01-26 12:30 ` Peter Zijlstra
2009-01-26 13:24 ` Louis Rilling
2009-01-26 13:41 ` Peter Zijlstra [this message]
2009-01-26 14:00 ` Louis Rilling
2009-01-26 14:19 ` Peter Zijlstra
2009-01-26 14:55 ` Louis Rilling
2009-01-28 3:05 ` [Cluster-devel] " Joel Becker
2009-01-28 3:05 ` Joel Becker
2009-01-28 3:41 ` [Cluster-devel] " Joel Becker
2009-01-28 3:41 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232977283.4863.79.camel@laptop \
--to=peterz@infradead.org \
--cc=Joel.Becker@oracle.com \
--cc=Louis.Rilling@kerlabs.com \
--cc=akpm@linux-foundation.org \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.