From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1brlqw-0007iW-H1 for qemu-devel@nongnu.org; Wed, 05 Oct 2016 09:03:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1brlqr-0003GA-Hc for qemu-devel@nongnu.org; Wed, 05 Oct 2016 09:03:17 -0400 Date: Wed, 5 Oct 2016 09:02:58 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1233045948.581343.1475672578009.JavaMail.zimbra@redhat.com> In-Reply-To: <87bmyzvuqn.fsf@dusky.pond.sub.org> References: <20160922203927.28241-1-marcandre.lureau@redhat.com> <20160922203927.28241-4-marcandre.lureau@redhat.com> <8760p7yv8n.fsf@dusky.pond.sub.org> <934105962.522999.1475662607447.JavaMail.zimbra@redhat.com> <87bmyzvuqn.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 3/3] tests: start generic qemu-qmp tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , paolo bonzini , qemu-devel@nongnu.org, qemu-stable@nongnu.org Hi ----- Original Message ----- -snip- > > I'd be willing to take this as is with a suitable TODO comment > explaining where we want to go with this file. Perhaps > > /* > * This program tests QMP commands that aren't interesting enough to > * warrant their own test program. > * > * TODO The tests we got here now aren't good examples, because they > * don't really exercise the commands, but only demonstrate specific > * bugs we've fixed. > */ > > What do you think? It looks like a comment that may stale. I have a few tests in some wip branch that will go naturally there, so I hope it won't remain bug-fix only checks. I can't say how long it will take to get there though, so I am fine with a comment anyway, perhaps without TODO? thanks