From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LRzYK-0006sv-Gw for mharc-grub-devel@gnu.org; Tue, 27 Jan 2009 20:49:16 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LRzYI-0006sq-Ms for grub-devel@gnu.org; Tue, 27 Jan 2009 20:49:14 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LRzYG-0006se-9S for grub-devel@gnu.org; Tue, 27 Jan 2009 20:49:13 -0500 Received: from [199.232.76.173] (port=45293 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LRzYG-0006sb-4g for grub-devel@gnu.org; Tue, 27 Jan 2009 20:49:12 -0500 Received: from c60.cesmail.net ([216.154.195.49]:55258) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LRzYF-00068W-Nm for grub-devel@gnu.org; Tue, 27 Jan 2009 20:49:11 -0500 Received: from unknown (HELO smtprelay1.cesmail.net) ([192.168.1.111]) by c60.cesmail.net with ESMTP; 27 Jan 2009 20:49:08 -0500 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay1.cesmail.net (Postfix) with ESMTPSA id AA0CE34C6D for ; Tue, 27 Jan 2009 20:49:46 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <497E00B1.3090001@impulze.org> References: <49771040.7010509@impulze.org> <1232559057.17462.2.camel@dv> <49799320.1000300@impulze.org> <1232944909.1604.18.camel@dv> <497E00B1.3090001@impulze.org> Content-Type: text/plain Date: Tue, 27 Jan 2009 20:49:05 -0500 Message-Id: <1233107345.8331.7.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 (2.24.3-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2009 01:49:15 -0000 On Mon, 2009-01-26 at 19:28 +0100, Daniel Mierswa wrote: > On 26.01.2009 05:41, Pavel Roskin wrote: > > I'll appreciate if you write your Changelog entries according to the GNU > > coding standards. In particular, please don't abbreviate function > > names. > Ok, second try. I should have told you that I had applied your patch with rewritten ChangeLog entries. A quick look at your "second try" shows that you didn't check the GNU coding standards. You can find it using Google or another search engine. The part dealing with ChangeLogs is here: http://www.gnu.org/prep/standards/standards.html#Change-Logs > > We have a very similar function search_fs_uuid() in disk/fs_uuid.c, and > > it still uses grub_strcmp(). Should it be using grub_strcasecmp() as > > well? Can we export that function to reuse it in commands/search.c? > Yes it should use grub_strcasecmp, thanks for noticing. I don't know > exactly if we can reuse that function at another place. I leave that to > someone who knows where this code is executed. :-) The code is executed when the disk is referenced by its UUID. OK, I'll take care of it. -- Regards, Pavel Roskin