From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LS1dm-0006az-0C for mharc-grub-devel@gnu.org; Tue, 27 Jan 2009 23:03:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LS1dj-0006aW-VT for grub-devel@gnu.org; Tue, 27 Jan 2009 23:02:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LS1dh-0006ZW-G0 for grub-devel@gnu.org; Tue, 27 Jan 2009 23:02:58 -0500 Received: from [199.232.76.173] (port=53071 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LS1dh-0006ZT-9x for grub-devel@gnu.org; Tue, 27 Jan 2009 23:02:57 -0500 Received: from c60.cesmail.net ([216.154.195.49]:8596) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LS1dg-0002lO-PQ for grub-devel@gnu.org; Tue, 27 Jan 2009 23:02:56 -0500 Received: from unknown (HELO smtprelay1.cesmail.net) ([192.168.1.111]) by c60.cesmail.net with ESMTP; 27 Jan 2009 23:02:55 -0500 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay1.cesmail.net (Postfix) with ESMTPSA id 41D7F34C6D for ; Tue, 27 Jan 2009 23:03:34 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1233107345.8331.7.camel@dv> References: <49771040.7010509@impulze.org> <1232559057.17462.2.camel@dv> <49799320.1000300@impulze.org> <1232944909.1604.18.camel@dv> <497E00B1.3090001@impulze.org> <1233107345.8331.7.camel@dv> Content-Type: text/plain Date: Tue, 27 Jan 2009 23:02:52 -0500 Message-Id: <1233115372.2431.51.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 (2.24.3-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] caseless uuid detection, fixed wrong behaviour for strncasecmp, added strcasecmp X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2009 04:03:00 -0000 On Tue, 2009-01-27 at 20:49 -0500, Pavel Roskin wrote: > > > We have a very similar function search_fs_uuid() in disk/fs_uuid.c, and > > > it still uses grub_strcmp(). Should it be using grub_strcasecmp() as > > > well? Can we export that function to reuse it in commands/search.c? P.S. The reuse would be impractical. fs_uuid is a separate module, not the core. Reusing search_fs_uuid() would make the "search" module depend on "fs_uuid". In my opinion, it's not worth the trouble to introduce that dependency. It's not like we would save a lot of code. -- Regards, Pavel Roskin