From: Matt Mackall <mpm@selenic.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Ira Snyder <iws@ovro.caltech.edu>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: speed up request_firmware()
Date: Wed, 28 Jan 2009 12:35:22 -0600 [thread overview]
Message-ID: <1233167722.18091.2.camel@calx> (raw)
In-Reply-To: <20090128181117.35fb319b@lxorguk.ukuu.org.uk>
On Wed, 2009-01-28 at 18:11 +0000, Alan Cox wrote:
> > Without this patch, loading a 12MB firmware image (FPGA bitfiles) called
> > vmalloc() approximately 3000 times. With the patch, vmalloc() is only
> > called 13 times, however, some memory is wasted until firmware_release() is
> > called. Usually, this happens very quickly, so it shouldn't be a problem.
>
> Particularly on 32bit x86 vmalloc memory space is very precious so while
> the current buffer size default may be too small doubling repeatedly is
> not a good model IMHO.
How about a small exponent like 1.1?
--
http://selenic.com : development and support for Mercurial and Linux
next prev parent reply other threads:[~2009-01-28 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 18:04 [PATCH] firmware: speed up request_firmware() Ira Snyder
2009-01-28 18:11 ` Alan Cox
2009-01-28 18:35 ` Matt Mackall [this message]
2009-01-28 19:03 ` Andrey Borzenkov
2009-01-28 19:45 ` Alan Cox
2009-01-28 20:34 ` Ira Snyder
2009-04-03 6:46 ` Clemens Ladisch
2009-04-03 17:25 ` Andrey Borzenkov
2009-04-06 8:43 ` Clemens Ladisch
2009-04-09 19:08 ` David Woodhouse
2009-04-10 5:03 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233167722.18091.2.camel@calx \
--to=mpm@selenic.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.