From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Roel Kluin <roel.kluin@gmail.com>, Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 09/10] Staging: usbip: usbip_start_threads(): handle kernel_thread failure
Date: Wed, 28 Jan 2009 15:26:49 -0800 [thread overview]
Message-ID: <1233185210-23098-9-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20090128232319.GA23009@kroah.com>
From: Roel Kluin <roel.kluin@gmail.com>
kernel_thread may fail, notice this.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/staging/usbip/usbip_common.c | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/usbip/usbip_common.c b/drivers/staging/usbip/usbip_common.c
index 72e2092..22f93dd 100644
--- a/drivers/staging/usbip/usbip_common.c
+++ b/drivers/staging/usbip/usbip_common.c
@@ -406,8 +406,20 @@ void usbip_start_threads(struct usbip_device *ud)
/*
* threads are invoked per one device (per one connection).
*/
- kernel_thread(usbip_thread, (void *)&ud->tcp_rx, 0);
- kernel_thread(usbip_thread, (void *)&ud->tcp_tx, 0);
+ int retval;
+
+ retval = kernel_thread(usbip_thread, (void *)&ud->tcp_rx, 0);
+ if (retval < 0) {
+ printk(KERN_ERR "Creating tcp_rx thread for ud %p failed.\n",
+ ud);
+ return;
+ }
+ retval = kernel_thread(usbip_thread, (void *)&ud->tcp_tx, 0);
+ if (retval < 0) {
+ printk(KERN_ERR "Creating tcp_tx thread for ud %p failed.\n",
+ ud);
+ return;
+ }
/* confirm threads are starting */
wait_for_completion(&ud->tcp_rx.thread_done);
--
1.6.0.2
next prev parent reply other threads:[~2009-01-28 23:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 23:23 [GIT PATCH] STAGING patches for 2.6-git Greg KH
2009-01-28 23:26 ` [PATCH 01/10] Staging: comedi: fix Kbuild Greg Kroah-Hartman
2009-01-28 23:26 ` [PATCH 02/10] Staging: meilhaus: " Greg Kroah-Hartman
2009-01-28 23:26 ` [PATCH 03/10] Staging: android: binder: fix arm build errors Greg Kroah-Hartman
2009-01-28 23:26 ` [PATCH 04/10] Staging: android: timed_gpio: Fix build to build on kernels after 2.6.25 Greg Kroah-Hartman
2009-01-28 23:26 ` [PATCH 05/10] Staging: android: fix build error on 64bit boxes Greg Kroah-Hartman
2009-01-28 23:26 ` [PATCH 06/10] Staging: android: Add lowmemorykiller documentation Greg Kroah-Hartman
2009-01-28 23:26 ` [PATCH 07/10] Staging: android: task_get_unused_fd_flags: fix the wrong usage of tsk->signal Greg Kroah-Hartman
2009-01-28 23:26 ` [PATCH 08/10] staging: agnx: drivers/staging/agnx/agnx.h needs <linux/io.h> Greg Kroah-Hartman
2009-01-28 23:26 ` Greg Kroah-Hartman [this message]
2009-01-28 23:26 ` [PATCH 10/10] Staging: poch: fix verification of memory area Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233185210-23098-9-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.