From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LSMQa-0000VI-26 for mharc-grub-devel@gnu.org; Wed, 28 Jan 2009 21:14:48 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LSMQW-0000UX-0N for grub-devel@gnu.org; Wed, 28 Jan 2009 21:14:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LSMQU-0000UI-Dy for grub-devel@gnu.org; Wed, 28 Jan 2009 21:14:43 -0500 Received: from [199.232.76.173] (port=35146 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSMQU-0000UF-7I for grub-devel@gnu.org; Wed, 28 Jan 2009 21:14:42 -0500 Received: from c60.cesmail.net ([216.154.195.49]:51174) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LSMQT-0002Ak-Rb for grub-devel@gnu.org; Wed, 28 Jan 2009 21:14:42 -0500 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 28 Jan 2009 21:14:38 -0500 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 38A4F34C6D; Wed, 28 Jan 2009 21:29:26 -0500 (EST) From: Pavel Roskin To: grub-devel@gnu.org, Robert Millan Content-Type: text/plain Date: Wed, 28 Jan 2009 21:14:34 -0500 Message-Id: <1233195275.2727.18.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 (2.24.3-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Subject: Cross-compilation check broken X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2009 02:14:44 -0000 Hello, Robert! Your commit 1955 breaks my script for testing PowerPC. That's the script: #!/bin/sh set -e CROSS_PATH=/home/proski/src/buildroot/build_powerpc/staging_dir/usr/bin PATH=$CROSS_PATH:$PATH ./configure --with-platform=ieee1275 --target=powerpc-linux make -j2 ./grub-mkrescue --grub-mkimage=./grub-mkelfimage --pkglibdir=. grub.iso qemu-system-ppc -nographic -cdrom grub.iso -boot d I compile for target "powerpc-linux" and I have powerpc-linux-gcc in the PATH. However, I'm using native tools. I'm not interested in running tools in an emulator (actually, I have another script that does it). Therefore, build and host are the same, so TARGET_CC is set to gcc. The new check must be wrong. TARGET_CC is used to build executables for the target system. It should be found using the specified target even if the tools are compiled natively. Actually, the original check wasn't particularly good. Maybe we could check if target_alias is defined? Or maybe we could always check for TARGET_CC? -- Regards, Pavel Roskin