From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LSZcC-0002JH-D0 for mharc-grub-devel@gnu.org; Thu, 29 Jan 2009 11:19:40 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LSZc9-0002GU-QE for grub-devel@gnu.org; Thu, 29 Jan 2009 11:19:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LSZc5-0002BJ-Ot for grub-devel@gnu.org; Thu, 29 Jan 2009 11:19:37 -0500 Received: from [199.232.76.173] (port=44943 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LSZc5-0002B3-HT for grub-devel@gnu.org; Thu, 29 Jan 2009 11:19:33 -0500 Received: from c60.cesmail.net ([216.154.195.49]:31960) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1LSZc5-0007oX-6C for grub-devel@gnu.org; Thu, 29 Jan 2009 11:19:33 -0500 Received: from unknown (HELO smtprelay2.cesmail.net) ([192.168.1.112]) by c60.cesmail.net with ESMTP; 29 Jan 2009 11:19:31 -0500 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by smtprelay2.cesmail.net (Postfix) with ESMTPSA id 4856B34C6D for ; Thu, 29 Jan 2009 11:34:25 -0500 (EST) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20090129130737.GD15436@thorin> References: <1233195275.2727.18.camel@dv> <20090129130737.GD15436@thorin> Content-Type: text/plain Date: Thu, 29 Jan 2009 11:19:29 -0500 Message-Id: <1233245969.2910.19.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 (2.24.3-1.fc10) Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Cross-compilation check broken X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jan 2009 16:19:38 -0000 On Thu, 2009-01-29 at 14:07 +0100, Robert Millan wrote: > This check looks really confusing. I naively assumed it was checking if we're > cross-compiling like the comment said ;-) I agree, the comment is misleading. We actually check for the second set of tools there, which is used to build files for the target. The first set is used to build for the host, and it can be a cross-compiler as well. > But if it really meant to compare target with host, I think it should be: > > if test "x$target_cpu" != "x$host_cpu"; then > > rather than what was before: > > if test "x$target" != "x$host"; then > > Since "$target_os" has no real meaning. Does that work for you? I understand that you are trying to exorcise "$target_os" by all means. By from the user standpoint, the second set of tools is needed if the "--target" option was specified and its argument is different from the one for the "--host" option. I would also like to get rid of ac_tool_prefix. I'll have a look. I assume we can always look for $target_alias-gcc without falling back to $target_alias-cc and $target_alias-egcs. -- Regards, Pavel Roskin