From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755483AbZA3Tl6 (ORCPT ); Fri, 30 Jan 2009 14:41:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752663AbZA3Tlt (ORCPT ); Fri, 30 Jan 2009 14:41:49 -0500 Received: from accolon.hansenpartnership.com ([76.243.235.52]:50866 "EHLO accolon.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752284AbZA3Tls (ORCPT ); Fri, 30 Jan 2009 14:41:48 -0500 Subject: Re: [PATCH] voyager: fix up for moving the generic smp call func to pointers From: James Bottomley To: Ingo Molnar Cc: linux-kernel , Thomas Gleixner , "H. Peter Anvin" In-Reply-To: <20090130193849.GC32705@elte.hu> References: <1233340524.3248.45.camel@localhost.localdomain> <20090130185411.GA9984@elte.hu> <1233341963.3248.48.camel@localhost.localdomain> <20090130193849.GC32705@elte.hu> Content-Type: text/plain Date: Fri, 30 Jan 2009 19:41:49 +0000 Message-Id: <1233344509.3248.58.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-01-30 at 20:38 +0100, Ingo Molnar wrote: > * James Bottomley wrote: > > > On Fri, 2009-01-30 at 19:54 +0100, Ingo Molnar wrote: > > > James, > > > > > > * James Bottomley wrote: > > > > > > > commit e7986739a76cde5079da08809d8bbc6878387ae0 > > > > Author: Mike Travis > > > > Date: Tue Dec 16 17:33:52 2008 -0800 > > > > > > > > x86 smp: modify send_IPI_mask interface to accept cpumask_t pointers > > > > > > > > Changed all the IPI ops to take pointers, but didn't update voyager, > > > > which is now broken. Make the changes in voyager as well. > > > > > > Note: earlier this week i've rearchitectured the x86 subarchitecture and > > > APIC code - so there's a whole lot more to be done on the Voyager side > > > than just the cpumask conversion. > > > > Not for 2.6.29 there isn't. > > > > > The x86/Voyager subarch is not fully ported yet (i cleaned up its Kconfig > > > impact already) and hence it is disabled for the time being. It ought to > > > be relatively straightforward to port it to the new code - if you are > > > interested in doing that. > > > > > > You can find the latest code in tip/master at: > > > > > > http://people.redhat.com/mingo/tip.git/README > > > > > > it's tentatively aimed for v2.6.30. > > > > Right, and I'll fix the rest for 2.6.30. [...] > > ok. > > > [...] However, this patch is needed now to get 2.6.29-rc3 to boot. > > and there's also the other ones. We can put them in now that we've got the > new subarch code. Could you send a pull request with all the voyager fixes > collected into one tree? Sure, they're currently all here: master.kernel.org:/pub/scm/linux/kernel/git/jejb/voyager-2.6.git James