From: Yann Simon <yann.simon.fr@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>,
Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org
Subject: [PATCH JGIT] simplify loop with if and do while
Date: Sat, 31 Jan 2009 15:25:09 +0100 [thread overview]
Message-ID: <1233411909.8213.0.camel@localhost> (raw)
replace if(condition) { do { } while (condition) } by while (condition)
{ }
Signed-off-by: Yann Simon <yann.simon.fr@gmail.com>
---
.../src/org/spearce/jgit/lib/Repository.java | 18
+++++++-----------
1 files changed, 7 insertions(+), 11 deletions(-)
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
index 038a869..b6efac1 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
@@ -247,11 +247,9 @@ public File toFile(final AnyObjectId objectId) {
public boolean hasObject(final AnyObjectId objectId) {
final PackFile[] packs = packs();
int k = packs.length;
- if (k > 0) {
- do {
- if (packs[--k].hasObject(objectId))
- return true;
- } while (k > 0);
+ while (k > 0) {
+ if (packs[--k].hasObject(objectId))
+ return true;
}
return toFile(objectId).isFile();
}
@@ -288,12 +286,10 @@ public ObjectLoader openObject(final WindowCursor
curs, final AnyObjectId id)
throws IOException {
final PackFile[] packs = packs();
int k = packs.length;
- if (k > 0) {
- do {
- final ObjectLoader ol = packs[--k].get(curs, id);
- if (ol != null)
- return ol;
- } while (k > 0);
+ while (k > 0) {
+ final ObjectLoader ol = packs[--k].get(curs, id);
+ if (ol != null)
+ return ol;
}
try {
return new UnpackedObjectLoader(this, id);
--
1.6.0.6
reply other threads:[~2009-01-31 14:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233411909.8213.0.camel@localhost \
--to=yann.simon.fr@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.