From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Mon, 4 Dec 2017 09:36:43 -0500 (EST) Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Fix gfs2_log_write and eliminate gfs2_log_bmap In-Reply-To: <234147738.38091705.1512397985362.JavaMail.zimbra@redhat.com> References: <487120039.37168024.1512149649698.JavaMail.zimbra@redhat.com> <2c3401fc-12cc-1af2-fc25-818a22a15c40@redhat.com> <234147738.38091705.1512397985362.JavaMail.zimbra@redhat.com> Message-ID: <1233586096.38093272.1512398203079.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit | As explained in my previous email: "Death by a thousand cuts." | I much prefer the readability of one 17-line function to two | functions of 9 lines each. Make that one 9 line function and one 11 line function, since I'd need to add a check for the return code to get the same result. Bob Peterson