From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756028AbZBBPtS (ORCPT ); Mon, 2 Feb 2009 10:49:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751557AbZBBPtG (ORCPT ); Mon, 2 Feb 2009 10:49:06 -0500 Received: from acsinet11.oracle.com ([141.146.126.233]:40341 "EHLO acsinet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752137AbZBBPtF (ORCPT ); Mon, 2 Feb 2009 10:49:05 -0500 Subject: Re: [RFC v7] wait: prevent exclusive waiter starvation From: Chris Mason To: Andrew Morton Cc: Oleg Nesterov , Johannes Weiner , Peter Zijlstra , Matthew Wilcox , Chuck Lever , Nick Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , stable@kernel.org In-Reply-To: <1233239675.10354.18.camel@think.oraclecorp.com> References: <20090123095904.GA22890@cmpxchg.org> <20090123113541.GB12684@redhat.com> <20090123133050.GA19226@redhat.com> <20090126215957.GA3889@cmpxchg.org> <20090127032359.GA17359@redhat.com> <20090127193434.GA19673@cmpxchg.org> <20090127200544.GA28843@redhat.com> <20090128091453.GA22036@cmpxchg.org> <20090129044227.GA5231@redhat.com> <20090128233734.81d8004a.akpm@linux-foundation.org> <20090129083108.GA27495@redhat.com> <20090129011143.884e5573.akpm@linux-foundation.org> <1233239675.10354.18.camel@think.oraclecorp.com> Content-Type: text/plain Date: Mon, 02 Feb 2009 10:47:47 -0500 Message-Id: <1233589667.18113.24.camel@think.oraclecorp.com> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 Content-Transfer-Encoding: 7bit X-Source-IP: acsmt701.oracle.com [141.146.40.71] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090202.498715AB.02D8:SCFSTAT928724,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2009-01-29 at 09:34 -0500, Chris Mason wrote: > > > > So I think we're saying that > > > > lock_page_killable-avoid-lost-wakeups.patch actually did fix the bug? > > > > > > I think yes, > > > > > Our test case that was able to reliably trigger the bug was fixed by > lock_page_killable-avoid-lost-wakeups.patch. > > I'll ask them to test v7 as well. The run takes about a day, so > confirmation will take a bit. v7 went through a total of 5 runs and passed all of them. Unpatched we would fail after one run, so I think this does fix it. -chris From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id B789B5F0001 for ; Mon, 2 Feb 2009 10:48:24 -0500 (EST) Subject: Re: [RFC v7] wait: prevent exclusive waiter starvation From: Chris Mason In-Reply-To: <1233239675.10354.18.camel@think.oraclecorp.com> References: <20090123095904.GA22890@cmpxchg.org> <20090123113541.GB12684@redhat.com> <20090123133050.GA19226@redhat.com> <20090126215957.GA3889@cmpxchg.org> <20090127032359.GA17359@redhat.com> <20090127193434.GA19673@cmpxchg.org> <20090127200544.GA28843@redhat.com> <20090128091453.GA22036@cmpxchg.org> <20090129044227.GA5231@redhat.com> <20090128233734.81d8004a.akpm@linux-foundation.org> <20090129083108.GA27495@redhat.com> <20090129011143.884e5573.akpm@linux-foundation.org> <1233239675.10354.18.camel@think.oraclecorp.com> Content-Type: text/plain Date: Mon, 02 Feb 2009 10:47:47 -0500 Message-Id: <1233589667.18113.24.camel@think.oraclecorp.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: Oleg Nesterov , Johannes Weiner , Peter Zijlstra , Matthew Wilcox , Chuck Lever , Nick Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , stable@kernel.org List-ID: On Thu, 2009-01-29 at 09:34 -0500, Chris Mason wrote: > > > > So I think we're saying that > > > > lock_page_killable-avoid-lost-wakeups.patch actually did fix the bug? > > > > > > I think yes, > > > > > Our test case that was able to reliably trigger the bug was fixed by > lock_page_killable-avoid-lost-wakeups.patch. > > I'll ask them to test v7 as well. The run takes about a day, so > confirmation will take a bit. v7 went through a total of 5 runs and passed all of them. Unpatched we would fail after one run, so I think this does fix it. -chris -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org