From: Alexey Klimov <klimov.linux@gmail.com>
To: Douglas Schilling Landgraf <dougsland@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: [patch review 2/8] radio-mr800: place dev_err instead of dev_warn
Date: Tue, 03 Feb 2009 04:08:02 +0300 [thread overview]
Message-ID: <1233623282.17456.254.camel@tux.localhost> (raw)
There should be dev_err message if video_register_device() fails.
Correct this situation.
Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>
--
diff -r ed1aa70cfdfa linux/drivers/media/radio/radio-mr800.c
--- a/linux/drivers/media/radio/radio-mr800.c Mon Feb 02 02:29:52 2009 +0300
+++ b/linux/drivers/media/radio/radio-mr800.c Mon Feb 02 02:52:52 2009 +0300
@@ -672,7 +672,7 @@
video_set_drvdata(radio->videodev, radio);
retval = video_register_device(radio->videodev, VFL_TYPE_RADIO, radio_nr);
if (retval < 0) {
- dev_warn(&intf->dev, "could not register video device\n");
+ dev_err(&intf->dev, "could not register video device\n");
video_device_release(radio->videodev);
kfree(radio->buffer);
kfree(radio);
--
Best regards, Klimov Alexey
reply other threads:[~2009-02-03 1:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233623282.17456.254.camel@tux.localhost \
--to=klimov.linux@gmail.com \
--cc=dougsland@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.