Re: crypto: sha-s390 - Switch to shash

[Jan Glauber <jang@linux.vnet.ibm.com>]

On Tue, 2009-02-03 at 12:48 +1100, Herbert Xu wrote:
> On Mon, Feb 02, 2009 at 06:01:07PM +0000, Jan Glauber wrote:
> >
> > The patch is not yet in cryptodev, so I applied it on top of cryptodev.
> > Compiling it gives me the following error:
> > 
> >  CC [M]  arch/s390/crypto/sha256_s390.o
> > arch/s390/crypto/sha_common.c: In function ‘s390_sha_update’:
> > arch/s390/crypto/sha_common.c:23: error: implicit declaration of function ‘crypto_shash_blocksize’
> > make[1]: *** [arch/s390/crypto/sha_common.o] Error 1
> 
> Thanks for testing! It turns out that this was the first in-tree
> user for crypto_shash_blocksize so I'll need to add it.


With this little typo-patch shash works fine on s390.

Cheers, Jan

--- ./arch/s390/crypto/sha256_s390.c.shash	2009-02-03 13:43:47.000000000
+0100
+++ ./arch/s390/crypto/sha256_s390.c	2009-02-03 13:43:53.000000000 +0100
@@ -26,7 +26,7 @@
 
 static int sha256_init(struct shash_desc *desc)
 {
-	struct s390_sha_ctx *sctx = shash_desc_ctx(tfm);
+	struct s390_sha_ctx *sctx = shash_desc_ctx(desc);
 
 	sctx->state[0] = SHA256_H0;
 	sctx->state[1] = SHA256_H1;


--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html