From: Dan Williams <dcbw@redhat.com>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: johannes@sipsolutions.net, libertas-dev@lists.infradead.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wireless: pos[4] tested twice, 2nd should be pos[5]
Date: Tue, 03 Feb 2009 11:39:32 -0500 [thread overview]
Message-ID: <1233679172.11344.59.camel@localhost.localdomain> (raw)
In-Reply-To: <49886DBD.9030302@gmail.com>
On Tue, 2009-02-03 at 17:15 +0100, Roel Kluin wrote:
> Is this what it should be? please review.
> ----------------->8----------------------8<------------------
>
> pos[4] can't be both 0x43 and 0x04, 2nd should be pos[5]
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Dan Williams <dcbw@redhat.com>
> ---
> diff --git a/drivers/net/wireless/libertas/scan.c b/drivers/net/wireless/libertas/scan.c
> index 57f6c12..00a57ed 100644
> --- a/drivers/net/wireless/libertas/scan.c
> +++ b/drivers/net/wireless/libertas/scan.c
> @@ -692,7 +692,7 @@ static int lbs_process_bss(struct bss_descriptor *bss,
> bss->wpa_ie_len);
> } else if (pos[1] >= MARVELL_MESH_IE_LENGTH &&
> pos[2] == 0x00 && pos[3] == 0x50 &&
> - pos[4] == 0x43 && pos[4] == 0x04) {
> + pos[4] == 0x43 && pos[5] == 0x04) {
> lbs_deb_scan("got mesh IE\n");
> bss->mesh = 1;
> } else {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2009-02-03 16:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 16:15 [PATCH] wireless: pos[4] tested twice, 2nd should be pos[5] Roel Kluin
2009-02-03 16:39 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233679172.11344.59.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.