From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Benjamin Krill <ben@codiert.org>
Cc: linuxppc-dev@ozlabs.org, vwool@ru.mvista.com,
linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
dwg@au1.ibm.com
Subject: Re: [PATCH v2] Check name property to determine partition nodes.
Date: Wed, 04 Feb 2009 15:09:02 +1100 [thread overview]
Message-ID: <1233720542.16867.187.camel@pasglop> (raw)
In-Reply-To: <20090123161805.GA2598@codiert.org>
On Fri, 2009-01-23 at 17:18 +0100, Benjamin Krill wrote:
> SLOF has a further node which could not be evaluate
> by the current routine. The current routine returns
> because the node hasn't the required reg property. As
> fix this patch adds a check to determine the partition
> child nodes. If the node is not an partition the number
> of total partitions will be decreased and loop continue
> with the next nodes.
Somebody on the MTD list is taking that ? David ? Or should I merge it
via powerpc ?
Cheers,
Ben.
> Signed-off-by: Benjamin Krill <ben@codiert.org>
> ---
> drivers/mtd/ofpart.c | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/ofpart.c b/drivers/mtd/ofpart.c
> index 9e45b3f..3e164f0 100644
> --- a/drivers/mtd/ofpart.c
> +++ b/drivers/mtd/ofpart.c
> @@ -46,6 +46,13 @@ int __devinit of_mtd_parse_partitions(struct device *dev,
> const u32 *reg;
> int len;
>
> + /* check if this is a partition node */
> + partname = of_get_property(pp, "name", &len);
> + if (strcmp(partname, "partition") != 0) {
> + nr_parts--;
> + continue;
> + }
> +
> reg = of_get_property(pp, "reg", &len);
> if (!reg || (len != 2 * sizeof(u32))) {
> of_node_put(pp);
next prev parent reply other threads:[~2009-02-04 4:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 16:18 [PATCH v2] Check name property to determine partition nodes Benjamin Krill
2009-02-04 4:09 ` Benjamin Herrenschmidt [this message]
2009-02-18 7:47 ` Benjamin Krill
2009-03-24 13:27 ` Benjamin Krill
2009-03-24 14:04 ` David Woodhouse
2009-03-24 14:04 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233720542.16867.187.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=ben@codiert.org \
--cc=dwg@au1.ibm.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=vwool@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.