All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaswinder Singh Rajput <jaswinder@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Arnd Bergmann <arnd@arndb.de>, Sam Ravnborg <sam@ravnborg.org>,
	alsa-devel@alsa-project.org, Ingo Molnar <mingo@elte.hu>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: usr/include/linux/soundcard.h warnings for 'make headers_check'
Date: Wed, 04 Feb 2009 17:01:37 +0530	[thread overview]
Message-ID: <1233747097.5563.29.camel@localhost.localdomain> (raw)
In-Reply-To: <s5hy6wma2zw.wl%tiwai@suse.de>

On Wed, 2009-02-04 at 11:52 +0100, Takashi Iwai wrote:
> At Wed, 04 Feb 2009 16:07:57 +0530,
> Jaswinder Singh Rajput wrote:
> > 
> > In kernel space we use USE_SEQ_MACROS in:
> > sound/oss/mpu401.c
> > sound/oss/midi_synth.c
> > 
> > so we can replace
> > #if (!defined(__KERNEL__) && !defined(KERNEL) && !defined(INKERNEL) && !defined(_KERNEL)) || defined(USE_SEQ_MACROS)
> > with
> > #ifdef USE_SEQ_MACROS
> 
> Then this will break user-space apps.  They don't define
> USE_SEQ_MACROS always.
> 

If userspace apps are coming through sys/soundcard.h we can define
USE_SEQ_MACROS in it 
OR 
define USE_SEQ_MACROS in linux/soundcard.h for userspace 
OR 
need to redefine better #ifdef

Thanks,
--
JSR

  reply	other threads:[~2009-02-04 11:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 15:38 usr/include/linux/soundcard.h warnings for 'make headers_check' Jaswinder Singh Rajput
2009-01-21  0:08 ` Takashi Iwai
2009-01-21  0:25   ` Jaswinder Singh Rajput
2009-01-21  5:41   ` Sam Ravnborg
2009-01-21  5:41     ` Sam Ravnborg
2009-02-03 20:27     ` Arnd Bergmann
2009-02-04  4:04       ` Jaswinder Singh Rajput
2009-02-04  6:39         ` Takashi Iwai
2009-02-04  6:39           ` Takashi Iwai
2009-02-04  8:34           ` Jaswinder Singh Rajput
2009-02-04  9:03             ` Takashi Iwai
2009-02-04  9:03               ` Takashi Iwai
2009-02-04 10:37               ` Jaswinder Singh Rajput
2009-02-04 10:52                 ` Takashi Iwai
2009-02-04 10:52                   ` Takashi Iwai
2009-02-04 11:31                   ` Jaswinder Singh Rajput [this message]
2009-02-04 11:43                     ` Takashi Iwai
2009-02-04 11:43                       ` Takashi Iwai
2009-02-04 12:51                       ` Arnd Bergmann
2009-02-04 12:58                         ` Takashi Iwai
2009-02-04 12:58                           ` Takashi Iwai
2009-02-04 13:44                         ` Jaswinder Singh Rajput
2009-02-04 13:49                           ` Takashi Iwai
2009-02-04 13:49                             ` Takashi Iwai
2009-02-04 14:02                           ` Arnd Bergmann
2009-02-09 23:06                             ` Takashi Iwai
2009-02-09 23:06                               ` Takashi Iwai
2009-01-24  6:50   ` Jaswinder Singh Rajput

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1233747097.5563.29.camel@localhost.localdomain \
    --to=jaswinder@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.