From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LUhUm-0004sI-Eb for mharc-grub-devel@gnu.org; Wed, 04 Feb 2009 08:08:48 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LUhUg-0004rm-4e for grub-devel@gnu.org; Wed, 04 Feb 2009 08:08:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LUhUd-0004rS-PS for grub-devel@gnu.org; Wed, 04 Feb 2009 08:08:41 -0500 Received: from [199.232.76.173] (port=32954 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LUhUd-0004rN-Af for grub-devel@gnu.org; Wed, 04 Feb 2009 08:08:39 -0500 Received: from nf-out-0910.google.com ([64.233.182.188]:58525) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LUhUc-0004i0-Lp for grub-devel@gnu.org; Wed, 04 Feb 2009 08:08:39 -0500 Received: by nf-out-0910.google.com with SMTP id c7so494971nfi.26 for ; Wed, 04 Feb 2009 05:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=32FcNVzNA5faG1dJG7n29olCxWv1l90o1jfh684Ehyw=; b=uCrWlwMtzo5+PHs9vLnwBYeN8miIkA5gNbywjqf6SRJnt5RLTZD98b0ZwOcmCSWgdU eq3X3xSnOSHqh/fRoLL/lXFyuDp+HHLEgokKygHE/cV6dYARiCHU9aM/vtWRB7rZ/FB9 qGA5JlYNmn2ABDjJus5KXRWDedLZUBa8mMxAc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=hNLnZdQN2yL+oAgZmDfOFlo2VCr3W05cWA2nM4kWnXSEJpA3j5JxyMGL4BRcyyvc8e Ce4yxEqOPulygc5jQgRjZGA2gmZb3+Fb9GhBMYkddyGR8TKKrtDi1CGV91yZjrIgqo2R 8PZhJKMU4dryylzTwuecEd2cPyFIKeeFvhasE= Received: by 10.67.89.1 with SMTP id r1mr3337103ugl.82.1233752916402; Wed, 04 Feb 2009 05:08:36 -0800 (PST) Received: from ?192.168.1.102? (213.37.137.93.dyn.user.ono.com [213.37.137.93]) by mx.google.com with ESMTPS id e1sm4937461ugf.51.2009.02.04.05.08.34 (version=SSLv3 cipher=RC4-MD5); Wed, 04 Feb 2009 05:08:35 -0800 (PST) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <1233733265.3441.6.camel@fz.local> References: <20080703140211.GA19341@thorin> <20080704000829.GE4074@thorin> <1215135163.26019.44.camel@localhost> <20080704142125.GC2663@thorin> <1215182702.26019.130.camel@localhost> <20080704185723.GB32625@thorin> <1215204095.26019.142.camel@localhost> <20080705120757.GA1647@thorin> <1215282973.26019.183.camel@localhost> <20080719142707.GA23778@thorin> <1233733265.3441.6.camel@fz.local> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-+ns4v1VL8OYB8DUzeFQw" Date: Wed, 04 Feb 2009 14:08:58 +0100 Message-Id: <1233752938.30696.4.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: grub-probe detects ext4 wronly as ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Feb 2009 13:08:42 -0000 --=-+ns4v1VL8OYB8DUzeFQw Content-Type: multipart/mixed; boundary="=-/alHNA8LTjdh8fUJ/ZO8" --=-/alHNA8LTjdh8fUJ/ZO8 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable El mi=C3=A9, 04-02-2009 a las 08:41 +0100, Felix Zielcke escribi=C3=B3: > Am Montag, den 11.08.2008, 16:14 +0200 schrieb Javier Mart=C3=ADn: > > Hi there, > >=20 > > After reading Felix's reply I've once again found your post and > > implemented your request, so here is a new version of the patch > > ("version 6"). Sorry for missing your message in the first instance... > > u_u >=20 > I'd like to bring this up again. > Now with that journal_dev bug (See [0] or [1]) it would be really nice > to have this commited. >=20 > [0] http://lists.gnu.org/archive/html/grub-devel/2009-02/msg00018.html > [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D502333 Well, I am happy to post a diff of the patch against current SVN head (r1973). I have personally confirmed (in a VM) that it: 1) Still builds (and even runs! ^^) 2) Works with existing ext2/3 file systems (I haven't checked ext4 FSs but the "extents" bit is marked as supported, so it should work) 3) Correctly rejects journal devices, which will then appear as "unknown filesystem" when accessed. --=-/alHNA8LTjdh8fUJ/ZO8 Content-Disposition: attachment; filename="ext2_incompat.patch.7" Content-Type: text/x-patch; name="ext2_incompat.patch.7"; charset="UTF-8" Content-Transfer-Encoding: base64 SW5kZXg6IGZzL2V4dDIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIGZzL2V4dDIuYwkocmV2aXNpw7NuOiAx OTczKQ0KKysrIGZzL2V4dDIuYwkoY29waWEgZGUgdHJhYmFqbykNCkBAIC03MSw4ICs3MSw1MyBA QA0KICAgICAgICAgID8gRVhUMl9HT09EX09MRF9JTk9ERV9TSVpFIFwNCiAgICAgICAgICA6IGdy dWJfbGVfdG9fY3B1MTYgKGRhdGEtPnNibG9jay5pbm9kZV9zaXplKSkNCiANCi0jZGVmaW5lIEVY VDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwJMHgwMDA0DQorLyogU3VwZXJibG9jayBmaWxl c3lzdGVtIGZlYXR1cmUgZmxhZ3MgKFJXIGNvbXBhdGlibGUpDQorICogQSBmaWxlc3lzdGVtIHdp dGggYW55IG9mIHRoZXNlIGVuYWJsZWQgY2FuIGJlIHJlYWQgYW5kIHdyaXR0ZW4gYnkgYSBkcml2 ZXINCisgKiB0aGF0IGRvZXMgbm90IHVuZGVyc3RhbmQgdGhlbSB3aXRob3V0IGNhdXNpbmcgbWV0 YWRhdGEvZGF0YSBjb3JydXB0aW9uICovDQorI2RlZmluZSBFWFQyX0ZFQVRVUkVfQ09NUEFUX0RJ Ul9QUkVBTExPQwkweDAwMDENCisjZGVmaW5lIEVYVDJfRkVBVFVSRV9DT01QQVRfSU1BR0lDX0lO T0RFUwkweDAwMDINCisjZGVmaW5lIEVYVDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwJCTB4 MDAwNA0KKyNkZWZpbmUgRVhUMl9GRUFUVVJFX0NPTVBBVF9FWFRfQVRUUgkJMHgwMDA4DQorI2Rl ZmluZSBFWFQyX0ZFQVRVUkVfQ09NUEFUX1JFU0laRV9JTk9ERQkweDAwMTANCisjZGVmaW5lIEVY VDJfRkVBVFVSRV9DT01QQVRfRElSX0lOREVYCQkweDAwMjANCisvKiBTdXBlcmJsb2NrIGZpbGVz eXN0ZW0gZmVhdHVyZSBmbGFncyAoUk8gY29tcGF0aWJsZSkNCisgKiBBIGZpbGVzeXN0ZW0gd2l0 aCBhbnkgb2YgdGhlc2UgZW5hYmxlZCBjYW4gYmUgc2FmZWx5IHJlYWQgYnkgYSBkcml2ZXIgdGhh dA0KKyAqIGRvZXMgbm90IHVuZGVyc3RhbmQgdGhlbSwgYnV0IHNob3VsZCBub3QgYmUgd3JpdHRl biB0bywgdXN1YWxseSBiZWNhdXNlDQorICogYWRkaXRpb25hbCBtZXRhZGF0YSBpcyByZXF1aXJl ZCAqLw0KKyNkZWZpbmUgRVhUMl9GRUFUVVJFX1JPX0NPTVBBVF9TUEFSU0VfU1VQRVIJMHgwMDAx DQorI2RlZmluZSBFWFQyX0ZFQVRVUkVfUk9fQ09NUEFUX0xBUkdFX0ZJTEUJMHgwMDAyDQorI2Rl ZmluZSBFWFQyX0ZFQVRVUkVfUk9fQ09NUEFUX0JUUkVFX0RJUgkweDAwMDQNCisjZGVmaW5lIEVY VDRfRkVBVFVSRV9ST19DT01QQVRfR0RUX0NTVU0JCTB4MDAxMA0KKyNkZWZpbmUgRVhUNF9GRUFU VVJFX1JPX0NPTVBBVF9ESVJfTkxJTksJMHgwMDIwDQorI2RlZmluZSBFWFQ0X0ZFQVRVUkVfUk9f Q09NUEFUX0VYVFJBX0lTSVpFCTB4MDA0MA0KKy8qIFN1cGVyYmxvY2sgZmlsZXN5c3RlbSBmZWF0 dXJlIGZsYWdzIChiYWNrLWluY29tcGF0aWJsZSkNCisgKiBBIGZpbGVzeXN0ZW0gd2l0aCBhbnkg b2YgdGhlc2UgZW5hYmxlZCBzaG91bGQgbm90IGJlIGF0dGVtcHRlZCB0byBiZSByZWFkDQorICog YnkgYSBkcml2ZXIgdGhhdCBkb2VzIG5vdCB1bmRlcnN0YW5kIHRoZW0sIHNpbmNlIHRoZXkgdXN1 YWxseSBpbmRpY2F0ZQ0KKyAqIG1ldGFkYXRhIGZvcm1hdCBjaGFuZ2VzIHRoYXQgbWlnaHQgY29u ZnVzZSB0aGUgcmVhZGVyLiAqLw0KKyNkZWZpbmUgRVhUMl9GRUFUVVJFX0lOQ09NUEFUX0NPTVBS RVNTSU9OCTB4MDAwMQ0KKyNkZWZpbmUgRVhUMl9GRUFUVVJFX0lOQ09NUEFUX0ZJTEVUWVBFCQkw eDAwMDINCisjZGVmaW5lIEVYVDNfRkVBVFVSRV9JTkNPTVBBVF9SRUNPVkVSCQkweDAwMDQgLyog TmVlZHMgcmVjb3ZlcnkgKi8NCisjZGVmaW5lIEVYVDNfRkVBVFVSRV9JTkNPTVBBVF9KT1VSTkFM X0RFVgkweDAwMDggLyogVm9sdW1lIGlzIGpvdXJuYWwgZGV2aWNlICovDQorI2RlZmluZSBFWFQy X0ZFQVRVUkVfSU5DT01QQVRfTUVUQV9CRwkJMHgwMDEwDQorI2RlZmluZSBFWFQ0X0ZFQVRVUkVf SU5DT01QQVRfRVhURU5UUwkJMHgwMDQwIC8qIEV4dGVudHMgdXNlZCAqLw0KKyNkZWZpbmUgRVhU NF9GRUFUVVJFX0lOQ09NUEFUXzY0QklUCQkweDAwODANCisjZGVmaW5lIEVYVDRfRkVBVFVSRV9J TkNPTVBBVF9GTEVYX0JHCQkweDAyMDANCiANCisvKiBUaGUgc2V0IG9mIGJhY2staW5jb21wYXRp YmxlIGZlYXR1cmVzIHRoaXMgZHJpdmVyIERPRVMgc3VwcG9ydC4gQWRkIChPUikNCisgKiBmbGFn cyBoZXJlIGFzIHRoZSByZWxhdGVkIGZlYXR1cmVzIGFyZSBpbXBsZW1lbnRlZCBpbnRvIHRoZSBk cml2ZXIgKi8NCisjZGVmaW5lIEVYVDJfRFJJVkVSX1NVUFBPUlRFRF9JTkNPTVBBVCAoIEVYVDJf RkVBVFVSRV9JTkNPTVBBVF9GSUxFVFlQRSBcDQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfRVhURU5UUyApDQorLyogTGlzdCBv ZiByYXRpb25hbGVzIGZvciB0aGUgaWdub3JlZCAiaW5jb21wYXRpYmxlIiBmZWF0dXJlczoNCisg KiBuZWVkc19yZWNvdmVyeTogTm90IHJlYWxseSBiYWNrLWluY29tcGF0aWJsZSAtIHdhcyBhZGRl ZCBhcyBzdWNoIHRvIGZvcmJpZA0KKyAqICAgICAgICAgICAgICAgICBleHQyIGRyaXZlcnMgZnJv bSBtb3VudGluZyBhbiBleHQzIHZvbHVtZSB3aXRoIGEgZGlydHkNCisgKiAgICAgICAgICAgICAg ICAgam91cm5hbCBiZWNhdXNlIHRoZXkgd2lsbCBpZ25vcmUgdGhlIGpvdXJuYWwsIGJ1dCB0aGUg bmV4dA0KKyAqICAgICAgICAgICAgICAgICBleHQzIGRyaXZlciB0byBtb3VudCB0aGUgdm9sdW1l IHdpbGwgZmluZCB0aGUgam91cm5hbCBhbmQNCisgKiAgICAgICAgICAgICAgICAgcmVwbGF5IGl0 LCBwb3RlbnRpYWxseSBjb3JydXB0aW5nIHRoZSBtZXRhZGF0YSB3cml0dGVuIGJ5DQorICogICAg ICAgICAgICAgICAgIHRoZSBleHQyIGRyaXZlcnMNCisgKi8NCisjZGVmaW5lIEVYVDJfRFJJVkVS X0lHTk9SRURfSU5DT01QQVQgKCBFWFQzX0ZFQVRVUkVfSU5DT01QQVRfUkVDT1ZFUiApDQorDQor DQogI2RlZmluZSBFWFQzX0pPVVJOQUxfTUFHSUNfTlVNQkVSCTB4YzAzYjM5OThVDQogDQogI2Rl ZmluZSBFWFQzX0pPVVJOQUxfREVTQ1JJUFRPUl9CTE9DSwkxDQpAQCAtNDg2LDEwICs1MzEsMTIg QEANCiAgIHJldHVybiAwOw0KIH0NCiANCisjZGVmaW5lIEVYVDJfRFJJVkVSX01PVU5UX0ZBSUwo bWVzc2FnZSkgeyBsb2NhbF9lcnJvciA9IChtZXNzYWdlKTsgZ290byBmYWlsOyB9DQogc3RhdGlj IHN0cnVjdCBncnViX2V4dDJfZGF0YSAqDQogZ3J1Yl9leHQyX21vdW50IChncnViX2Rpc2tfdCBk aXNrKQ0KIHsNCiAgIHN0cnVjdCBncnViX2V4dDJfZGF0YSAqZGF0YTsNCisgIGNvbnN0IGNoYXIg KmxvY2FsX2Vycm9yID0gMDsNCiANCiAgIGRhdGEgPSBncnViX21hbGxvYyAoc2l6ZW9mIChzdHJ1 Y3QgZ3J1Yl9leHQyX2RhdGEpKTsNCiAgIGlmICghZGF0YSkNCkBAIC00OTgsMTMgKzU0NSwxOSBA QA0KICAgLyogUmVhZCB0aGUgc3VwZXJibG9jay4gICovDQogICBncnViX2Rpc2tfcmVhZCAoZGlz aywgMSAqIDIsIDAsIHNpemVvZiAoc3RydWN0IGdydWJfZXh0Ml9zYmxvY2spLA0KICAgICAgICAg ICAgICAgICAgIChjaGFyICopICZkYXRhLT5zYmxvY2spOw0KLSAgaWYgKGdydWJfZXJybm8pDQot ICAgIGdvdG8gZmFpbDsNCisgIGlmIChncnViX2Vycm5vICE9IEdSVUJfRVJSX05PTkUpDQorICAg IEVYVDJfRFJJVkVSX01PVU5UX0ZBSUwoMCk7DQogDQogICAvKiBNYWtlIHN1cmUgdGhpcyBpcyBh biBleHQyIGZpbGVzeXN0ZW0uICAqLw0KICAgaWYgKGdydWJfbGVfdG9fY3B1MTYgKGRhdGEtPnNi bG9jay5tYWdpYykgIT0gRVhUMl9NQUdJQykNCi0gICAgZ290byBmYWlsOw0KKyAgICBFWFQyX0RS SVZFUl9NT1VOVF9GQUlMKCJub3QgYW4gZXh0MiBmaWxlc3lzdGVtIik7DQogICANCisgIC8qIENo ZWNrIHRoZSBGUyBkb2Vzbid0IGhhdmUgZmVhdHVyZSBiaXRzIGVuYWJsZWQgdGhhdCB3ZSBkb24n dCBzdXBwb3J0LiAqLw0KKyAgaWYgKGdydWJfbGVfdG9fY3B1MzIgKGRhdGEtPnNibG9jay5mZWF0 dXJlX2luY29tcGF0KQ0KKyAgICAgICAgJiB+KEVYVDJfRFJJVkVSX1NVUFBPUlRFRF9JTkNPTVBB VCB8IEVYVDJfRFJJVkVSX0lHTk9SRURfSU5DT01QQVQpKQ0KKyAgICBFWFQyX0RSSVZFUl9NT1VO VF9GQUlMKCJmaWxlc3lzdGVtIGhhcyB1bnN1cHBvcnRlZCBpbmNvbXBhdGlibGUgZmVhdHVyZXMi KTsNCisgICAgDQorICANCiAgIGRhdGEtPmRpc2sgPSBkaXNrOw0KIA0KICAgZGF0YS0+ZGlyb3Bl bi5kYXRhID0gZGF0YTsNCkBAIC01MTQsMTMgKzU2NywxNSBAQA0KICAgZGF0YS0+aW5vZGUgPSAm ZGF0YS0+ZGlyb3Blbi5pbm9kZTsNCiANCiAgIGdydWJfZXh0Ml9yZWFkX2lub2RlIChkYXRhLCAy LCBkYXRhLT5pbm9kZSk7DQotICBpZiAoZ3J1Yl9lcnJubykNCi0gICAgZ290byBmYWlsOw0KKyAg aWYgKGdydWJfZXJybm8gIT0gR1JVQl9FUlJfTk9ORSkNCisgICAgRVhUMl9EUklWRVJfTU9VTlRf RkFJTCgwKTsNCiAgIA0KICAgcmV0dXJuIGRhdGE7DQogDQogIGZhaWw6DQotICBncnViX2Vycm9y IChHUlVCX0VSUl9CQURfRlMsICJub3QgYW4gZXh0MiBmaWxlc3lzdGVtIik7DQorICAvKiBPbmx5 IGNhbGwgZ3J1Yl9lcnJvciBpZiB0aGUgZmFpbCB3YXMgX25vdF8gY2F1c2VkIGJ5IHVuZGVybHlp bmcgZXJyb3JzLiAgKi8NCisgIGlmIChsb2NhbF9lcnJvcikNCisgICAgZ3J1Yl9lcnJvciAoR1JV Ql9FUlJfQkFEX0ZTLCBsb2NhbF9lcnJvcik7DQogICBncnViX2ZyZWUgKGRhdGEpOw0KICAgcmV0 dXJuIDA7DQogfQ0K --=-/alHNA8LTjdh8fUJ/ZO8-- --=-+ns4v1VL8OYB8DUzeFQw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iQIcBAABAgAGBQJJiZNgAAoJEKSl+Fbdeo72yKAQALr5gM33MYsYsAB+ix09g3C4 iJSqvhTuxf+lthy6se8fh8FmeYZoct4PXL1hYKuaY6ICC/cm2BRgHVsXB89Nevj4 pH4ecDVeeLE2o+ch1JQQPfLHuZSHzCSmj/vJIroctVDi+jOe9TxiTCaIQZkd6BQj h/MLNEQArUndzeKfXDgMO4Y9E5iELL0u9g+mUHN3mfK2lArV31wEFeN+AZ1GGYSQ 7RwK+S7BssA9VEA36y229SuVsYQc7vTDF7ZvQi++Z1RUGk+PBXT+psfwHUaPamKS Ma/ADWHt0qP5hUNyOb3B9uMtF/dWZftU9Bqb2SKe/jOMRC8ES/wlMYj9O90g1nM7 fPSDzylmGzcOjZIS4KjSa6fxVFlvsuCe1zHAEHGdjnmiKhtsfqUDIw/FFxsFF6n5 pVn0nBRqGFNEhcEatRnHN3Hlr8npQEfveFjyp9B3CeTbDRR4slJ65wLgZlW0yjqQ wDJv8xSRqQFl4rhJNk3LgoLt0jxMeXTHJWLqVXvb2ch6T9Z0ta8pcnikj3RNSaGM EX26P8MEsP782GUUbyVMvKUXg3ylHgPp+2PUJM3n6I4K9gRvLb/VI7KaZaLxCMZI pKXWjldytlumQZavKIWwm7JgRkknEDZVVB2hUBq1cthIaLIOa/H8hMuNJtkXJd/8 cwgGgX4jlkYmI8btFNZ2 =1MzK -----END PGP SIGNATURE----- --=-+ns4v1VL8OYB8DUzeFQw--