From: Steven Rostedt <rostedt@goodmis.org>
To: Michael Neuling <mikey@neuling.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/2] powerpc, ftrace: fix compile error when modules not configured
Date: Fri, 06 Feb 2009 01:27:06 -0500 [thread overview]
Message-ID: <1233901626.16878.51.camel@localhost.localdomain> (raw)
In-Reply-To: <12951.1233901432@neuling.org>
On Fri, 2009-02-06 at 17:23 +1100, Michael Neuling wrote:
> In message <20090206060527.369616736@goodmis.org> you wrote:
> > From: Steven Rostedt <srostedt@redhat.com>
> >
> > Michael Neuling reported a compile bug when dynamic ftrace was
> > configured in and modules were not. This was due to the ftrace
> > code referencing module specific structures.
> >
> > Reported-by: Michael Neuling <mikey@neuling.org>
> > Signed-off-by: Steven Rostedt <srostedt@redhat.com>
>
> Steve,
>
> Thanks, fixes the error I was seeing.
Cool.
>
> As an aside, is there anyway we can merge some of the code in
> arch/powerpc/kernel/ftrace.c between 32 and 64bit? There seems to be a
> lot of repeated code in there with only minor changes.
It looks similar, but there's enough differences that I would like to
keep them separate. The code is complex enough and has a lot of subtle
differences between the two archs.
-- Steve
next prev parent reply other threads:[~2009-02-06 7:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 6:03 [PATCH 0/2] ftrace: updates for powerpc Steven Rostedt
2009-02-06 6:03 ` [PATCH 1/2] ftrace, powerpc: replace debug macro with proper pr_deug Steven Rostedt
2009-02-06 6:07 ` Steven Rostedt
2009-02-06 6:07 ` Steven Rostedt
2009-02-06 7:05 ` Benjamin Herrenschmidt
2009-02-06 13:29 ` Steven Rostedt
2009-02-06 6:03 ` [PATCH 2/2] powerpc, ftrace: fix compile error when modules not configured Steven Rostedt
2009-02-06 6:07 ` Steven Rostedt
2009-02-06 6:07 ` Steven Rostedt
2009-02-06 6:23 ` Michael Neuling
2009-02-06 6:23 ` Michael Neuling
2009-02-06 6:27 ` Steven Rostedt [this message]
2009-02-06 7:04 ` [PATCH 0/2] ftrace: updates for powerpc Benjamin Herrenschmidt
2009-02-06 13:28 ` Steven Rostedt
2010-05-10 10:27 ` hrtimer: about hres_active Iram Shahzad
2010-05-10 15:12 ` Thomas Gleixner
2010-05-11 1:39 ` Iram Shahzad
2010-05-11 8:33 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233901626.16878.51.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.