From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from fg-out-1718.google.com ([72.14.220.152]:62087 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759211AbZBFHOG (ORCPT ); Fri, 6 Feb 2009 02:14:06 -0500 Received: by fg-out-1718.google.com with SMTP id 16so393647fgg.17 for ; Thu, 05 Feb 2009 23:14:04 -0800 (PST) Subject: Re: [PATCH] Mantis Bug (was Technisat HD2 cannot szap/scan) From: Alexey Klimov To: Hans Werner Cc: gimli@dark-green.com, linux-dvb@linuxtv.org, linux-media@vger.kernel.org In-Reply-To: <20090205123431.29950@gmx.net> References: <49346726.7010303@insite.cz> <4934D218.4090202@verbraak.org> <4935B72F.1000505@insite.cz> <49371511.1060703@insite.cz> <4938C8BB.5040406@verbraak.org> <20081206170753.69410@gmx.net> <20081209153451.75130@gmx.net> <20081215143047.45940@gmx.net> <20090104192435.72460@gmx.net> <59327.62.178.208.71.1231173948.squirrel@webmail.dark-green.com> <20090105173606.271160@gmx.net> <40866.62.178.208.71.1231178997.squirrel@webmail.dark-green.com> <20090205123431.29950@gmx.net> Content-Type: text/plain Date: Fri, 06 Feb 2009 10:14:05 +0300 Message-Id: <1233904445.1916.139.camel@tux.localhost> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello, i'm sorry to bother you with this small thing. On Thu, 2009-02-05 at 13:34 +0100, Hans Werner wrote: > > Hi, > > > > checked it again. Your lnbp21 patch definitely kills S2 tuning > > on the Terratec Cinergy S2 PCI HD. > > > > mfg > > > > Edgar ( gimli ) Hucek > > > I looked at it again and here is a new patch to set the LNBP21 > options for the Twinhan VP-1041. This works better for me, including > DVB-S2 channels. The EN enable bit is now not permanently set so > sleep behavior is correct. > > Please note that I have a DiSEqC 1.2 rotor between the VP-1041 card > and the LNB. That is quite a normal configuration, but the driver was > probably not properly tested with rotors (and switches?) before. > > To rotate with scan-s2 use the patch I posted, which will be applied > there soon: > http://linuxtv.org/pipermail/linux-dvb/2009-January/031660.html > > Regards, > Hans > > Patch is against latest http://mercurial.intuxication.org/hg/s2-liplianin repo. > > Signed-off-by: Hans Werner > > diff -r 084878324629 linux/drivers/media/dvb/mantis/mantis_dvb.c > --- a/linux/drivers/media/dvb/mantis/mantis_dvb.c > +++ b/linux/drivers/media/dvb/mantis/mantis_dvb.c > @@ -239,7 +239,8 @@ int __devinit mantis_frontend_init(struc > vp1041_config.demod_address); > > if (stb6100_attach(mantis->fe, &vp1041_stb6100_config, &mantis->adapter)) { > - if (!lnbp21_attach(mantis->fe, &mantis->adapter, 0, 0)) { > + // static current limit, no extra 1V, high current limit, tone from DSQIN pin (stb0899) May i ask you not to use C99-style "// ..." comments ? Linux style for comments is the C89 "/* ... */" style. Honestly, when you do "make checkpatch" it will notify you about bad things (style of comments included). > + if (!lnbp21_attach(mantis->fe, &mantis->adapter, LNBP21_PCL , LNBP21_LLC | LNBP21_ISEL | LNBP21_TEN)) { > printk("%s: No LNBP21 found!\n", __FUNCTION__); > mantis->fe = NULL; > } > -- Best regards, Klimov Alexey