From: Mark McLoughlin <markmc@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Sheng Yang <sheng@linux.intel.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 0/3][v2] Fix racy in kvm_free_assigned_irq
Date: Fri, 06 Feb 2009 10:49:18 +0000 [thread overview]
Message-ID: <1233917358.27709.23.camel@blaa> (raw)
In-Reply-To: <49632297.5000008@redhat.com>
On Tue, 2009-01-06 at 11:21 +0200, Avi Kivity wrote:
> Sheng Yang wrote:
> > Hi Avi
> >
> > I just add a comment for kvm_free_assigned_irq(). The other things are all
> > the same as the patchset you have reviewed.
> >
>
> Applied, thanks.
These would make sense for 2.6.29, right?
I just saw the oops below when I killed a busy guest with an assigned
device, and it looks like it might be related.
Cheers,
Mark.
BUG: unable to handle kernel paging request at 0000000000200200
IP: [<ffffffff811945e4>] list_del+0x10/0x85
PGD 171c82067 PUD 1741d8067 PMD 0
Oops: 0000 [#1] SMP
last sysfs file: /sys/devices/pci0000:00/0000:00:1e.0/0000:01:00.0/local_cpus
CPU 1
Modules linked in: fuse i915 drm i2c_algo_bit ipt_MASQUERADE iptable_nat nf_nat sco bnep l2cap bluetooth sunrpc bridge stp xt_physdev ip6t_REJECT nf_conntrack_ipv6 ip6table_filter ip6_tables ipv6 dm_multipath kvm_intel kvm uinput snd_hda_codec_idt snd_hda_intel snd_hda_codec snd_hwdep snd_seq_dummy snd_seq_oss snd_seq_midi_event snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss snd_pcm snd_timer snd e1000e i2c_i801 soundcore snd_page_alloc i2c_core pcspkr joydev ata_generic pata_acpi [last unloaded: freq_table]
Pid: 17, comm: events/1 Tainted: G W 2.6.29-rc3 #30
RIP: 0010:[<ffffffff811945e4>] [<ffffffff811945e4>] list_del+0x10/0x85
RSP: 0018:ffff88017e165dc0 EFLAGS: 00010286
RAX: 0000000000200200 RBX: ffff8801628eca98 RCX: 0000000000000000
RDX: 0000000000050001 RSI: ffffffffa010ab98 RDI: ffff8801628eca98
RBP: ffff88017e165dd0 R08: 0000000000000002 R09: 0000000000000000
R10: 0000000000000000 R11: ffff88017e081140 R12: ffff880164b01c80
R13: ffff88016c1a91a8 R14: ffff88017e165e70 R15: 0000000000000006
FS: 0000000000000000(0000) GS:ffff88017e07b000(0000) knlGS:0000000000000000
CS: 0010 DS: 0018 ES: 0018 CR0: 000000008005003b
CR2: 0000000000200200 CR3: 0000000171c0c000 CR4: 00000000000426e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process events/1 (pid: 17, threadinfo ffff88017e164000, task ffff88017e180000)
Stack:
ffffffffa010ab98 ffff8801628ec000 ffff88017e165df0 ffffffffa010aba4
ffff88016c1a91b0 ffff88016c1a9188 ffff88017e165e40 ffffffffa010b93a
ffff88017e160148 000000007e160148 ffff88017e165e70 ffff88016c1a91b0
Call Trace:
[<ffffffffa010ab98>] ? kvm_put_kvm+0x32/0xac [kvm]
[<ffffffffa010aba4>] kvm_put_kvm+0x3e/0xac [kvm]
Message from [<ffffffffa010b93a>] kvm_assigned_dev_interrupt_work_handler+0x18d/0x19c [kvm]
[<ffffffff810598a8>] run_workqueue+0x103/0x20a
[<ffffffff81059856>] ? run_workqueue+0xb1/0x20a
[<ffffffffa010b7ad>] ? kvm_assigned_dev_interrupt_work_handler+0x0/0x19c [kvm]
[<ffffffff81059a8f>] worker_thread+0xe0/0xf1
[<ffffffff8105d6c8>] ? autoremove_wake_function+0x0/0x38
[<ffffffff810599af>] ? worker_thread+0x0/0xf1
[<ffffffff8105d350>] kthread+0x49/0x76
[<ffffffff8101262a>] child_rip+0xa/0x20
[<ffffffff81393972>] ? _spin_unlock_irq+0x2b/0x37
[<ffffffff8106b1f8>] ? trace_hardirqs_on+0xd/0xf
[<ffffffff81011f3e>] ? restore_args+0x0/0x30
[<ffffffff8105d307>] ? kthread+0x0/0x76
[<ffffffff81012620>] ? child_rip+0x0/0x20
Code: 7c 24 18 e8 98 00 00 00 4c 89 ef e8 7b fe ff ff 59 5b 41 5c 41 5d c9 c3 90 90 90 55 48 89 e5 53 48 89 fb 48 83 ec 08 48 8b 47 08 <48> 8b 00 48 39 f8 74 20 49 89 c0 48 89 f9 48 c7 c2 2a 7b 4d 81
RIP [<ffffffff811945e4>] list_del+0x10/0x85
RSP <ffff88017e165dc0>
CR2: 0000000000200200
next prev parent reply other threads:[~2009-02-06 10:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 2:03 [PATCH 0/3][v2] Fix racy in kvm_free_assigned_irq Sheng Yang
2009-01-06 2:03 ` [PATCH 1/3] KVM: Remove duplicated prototype of kvm_arch_destroy_vm Sheng Yang
2009-01-06 2:03 ` [PATCH 2/3] KVM: Add kvm_arch_sync_events to sync with asynchronize events Sheng Yang
2009-01-06 2:03 ` [PATCH 3/3] KVM: Fix racy in kvm_free_assigned_irq Sheng Yang
2009-01-06 9:21 ` [PATCH 0/3][v2] " Avi Kivity
2009-02-06 10:49 ` Mark McLoughlin [this message]
2009-02-06 12:33 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1233917358.27709.23.camel@blaa \
--to=markmc@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.