From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LVSvd-0005kU-W3 for mharc-grub-devel@gnu.org; Fri, 06 Feb 2009 10:47:42 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVSvb-0005j9-Lq for grub-devel@gnu.org; Fri, 06 Feb 2009 10:47:39 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVSvY-0005hj-Hs for grub-devel@gnu.org; Fri, 06 Feb 2009 10:47:39 -0500 Received: from [199.232.76.173] (port=41748 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVSvY-0005hd-Cd for grub-devel@gnu.org; Fri, 06 Feb 2009 10:47:36 -0500 Received: from moutng.kundenserver.de ([212.227.126.177]:52481) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LVSvX-0002q4-N5 for grub-devel@gnu.org; Fri, 06 Feb 2009 10:47:36 -0500 Received: from [85.180.30.135] (e180030135.adsl.alicedsl.de [85.180.30.135]) by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis) id 0ML31I-1LVSuf1E58-0000ZW; Fri, 06 Feb 2009 16:46:43 +0100 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <498BD389.60902@gmail.com> References: <1233866360.3426.31.camel@fz.local> <498BD389.60902@gmail.com> Content-Type: text/plain Date: Fri, 06 Feb 2009 16:46:44 +0100 Message-Id: <1233935204.3420.3.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX19HApD2AWa0W4X3rabWnL4G1x2ZpDEfMABsgwD Bjt2OJ/BaEfsK6Xvykfl5RLgNx5XiRMIQCTfOb2Z0Gfk/4BXm5 Zm8npjcdBOYzxWIfmSAxj0a3bK2GZcz X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] try to avoid false positives on FAT filesystem X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2009 15:47:40 -0000 Am Freitag, den 06.02.2009, 07:07 +0100 schrieb phcoder: > If I understood you correctly you propose to use partition table > information to determine filesystem. I'm personally against it. First of > all it isn't portable - it probably wouldn't work on GPT. Second if you > just do mkfs.* the partition type isn't changed. Linux ignores > partition type and so if your patch is applied there will be many bug > reports like "hey, *FS isn't detected". Finally sometimes you > intentionally change partition type in the technics like partition > hiding. IMO the correct solution to this problem is to make sure that > fat and ntfs are probed at last. Should we add a priority field for this? No I don't want to check the partition type. FAT partitions normally have the string FAT12/FAT16/FAT32 at the beginning of 512 bytes of the partition. But these DELL FAT partions have there the string .AT16 so it would be a solution for the Debian bug report we got. But yes the best would be to probe for FAT at last but I don't know how to change the order, in fs.lst FAT is listed after ext2 but it seems that FAT is checked before ext2. -- Felix Zielcke