From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LVssk-0004jW-Dp for mharc-grub-devel@gnu.org; Sat, 07 Feb 2009 14:30:26 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVssi-0004jR-8v for grub-devel@gnu.org; Sat, 07 Feb 2009 14:30:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVssg-0004jF-7n for grub-devel@gnu.org; Sat, 07 Feb 2009 14:30:22 -0500 Received: from [199.232.76.173] (port=38017 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVssg-0004jA-1k for grub-devel@gnu.org; Sat, 07 Feb 2009 14:30:22 -0500 Received: from moutng.kundenserver.de ([212.227.126.177]:63137) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LVssf-0004DL-HF for grub-devel@gnu.org; Sat, 07 Feb 2009 14:30:21 -0500 Received: from [85.180.62.134] (e180062134.adsl.alicedsl.de [85.180.62.134]) by mrelayeu.kundenserver.de (node=mrelayeu4) with ESMTP (Nemesis) id 0ML21M-1LVssU15MX-0007zc; Sat, 07 Feb 2009 20:30:10 +0100 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <1233752938.30696.4.camel@localhost> References: <20080703140211.GA19341@thorin> <20080704000829.GE4074@thorin> <1215135163.26019.44.camel@localhost> <20080704142125.GC2663@thorin> <1215182702.26019.130.camel@localhost> <20080704185723.GB32625@thorin> <1215204095.26019.142.camel@localhost> <20080705120757.GA1647@thorin> <1215282973.26019.183.camel@localhost> <20080719142707.GA23778@thorin> <1233733265.3441.6.camel@fz.local> <1233752938.30696.4.camel@localhost> Content-Type: text/plain; charset=utf-8 Date: Sat, 07 Feb 2009 20:30:14 +0100 Message-Id: <1234035014.3506.3.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V01U2FsdGVkX1+3bkYcgFq7GyMIj7BG02evDJMjtoXdUZWCodx oDYuQDddS5BcHb7qmfxjNkNlWFgBW1L78N+7SA4W1GoT5k3/P3 Ve2DHnMbnyn9372zGNXkFDVUBXnzkiq X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub-probe detects ext4 wronly as ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2009 19:30:24 -0000 Am Mittwoch, den 04.02.2009, 14:08 +0100 schrieb Javier Mart=C3=ADn: > Well, I am happy to post a diff of the patch against current SVN head > (r1973). I have personally confirmed (in a VM) that it: > 1) Still builds (and even runs! ^^) > 2) Works with existing ext2/3 file systems (I haven't checked ext4 FSs > but the "extents" bit is marked as supported, so it should work) > 3) Correctly rejects journal devices, which will then appear as "unknown > filesystem" when accessed. FLEX_BG needs to be added to the list of ignored flags. As Robert already said in his last reply to this thread [0] const char *local_error =3D 0; Please use NULL. + EXT2_DRIVER_MOUNT_FAIL(0); I share his opinion that this isn't needed. If you fix this and write a changelog then I commit this. [0] http://lists.gnu.org/archive/html/grub-devel/2008-08/msg00645.html --=20 Felix Zielcke