From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LVx0P-0004uy-N1 for mharc-grub-devel@gnu.org; Sat, 07 Feb 2009 18:54:37 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LVx0N-0004uM-DJ for grub-devel@gnu.org; Sat, 07 Feb 2009 18:54:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LVx0M-0004ts-1e for grub-devel@gnu.org; Sat, 07 Feb 2009 18:54:35 -0500 Received: from [199.232.76.173] (port=58083 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LVx0L-0004to-Rq for grub-devel@gnu.org; Sat, 07 Feb 2009 18:54:33 -0500 Received: from nf-out-0910.google.com ([64.233.182.189]:34078) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LVx0L-0002UO-2X for grub-devel@gnu.org; Sat, 07 Feb 2009 18:54:33 -0500 Received: by nf-out-0910.google.com with SMTP id c7so299224nfi.26 for ; Sat, 07 Feb 2009 15:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=DIBBt+N9BBHsnMyfVm9iRvbYCWvokjqw5n18C/k9tjU=; b=KDDW6BYEpe0Hv+Gl4KNJus9dfEZkotbZZE48o+4RvN7kq3lOmh4gAMRxp1lfm3hPxj Ei73I3pWYz53SfUZveCA/llwLJK/VoxBeS02qnQMBjXfnM/z/mybOxoUdAocVXv/P9QG kr6wvbYf88qsHo2X/7kHW9zRJS5xlPdHEFITw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=ORxxP1O8AO82o3BIEATn6CU9ashKdeFI8zvk6K0zAtLYXLCNtjd3jM31V4zJKgfi7V wtmaS0EmxnVcz5OByLt5PfW3PbWtzhxYNQOxdI1X8Ntasx55O5nAip1f5scNbdVT2Dwx J3DyKYdukRlke8Jhy0olsul+fjWuh66gYF8ak= Received: by 10.210.137.14 with SMTP id k14mr2570790ebd.175.1234050871300; Sat, 07 Feb 2009 15:54:31 -0800 (PST) Received: from ?192.168.1.102? (213.37.137.93.dyn.user.ono.com [213.37.137.93]) by mx.google.com with ESMTPS id x6sm417599gvf.12.2009.02.07.15.54.30 (version=SSLv3 cipher=RC4-MD5); Sat, 07 Feb 2009 15:54:30 -0800 (PST) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <1234035014.3506.3.camel@fz.local> References: <20080703140211.GA19341@thorin> <20080704000829.GE4074@thorin> <1215135163.26019.44.camel@localhost> <20080704142125.GC2663@thorin> <1215182702.26019.130.camel@localhost> <20080704185723.GB32625@thorin> <1215204095.26019.142.camel@localhost> <20080705120757.GA1647@thorin> <1215282973.26019.183.camel@localhost> <20080719142707.GA23778@thorin> <1233733265.3441.6.camel@fz.local> <1233752938.30696.4.camel@localhost> <1234035014.3506.3.camel@fz.local> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-ltcdYiS+tuWtSU289x+a" Date: Sun, 08 Feb 2009 00:54:29 +0100 Message-Id: <1234050869.15897.37.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: grub-probe detects ext4 wronly as ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Feb 2009 23:54:36 -0000 --=-ltcdYiS+tuWtSU289x+a Content-Type: multipart/mixed; boundary="=-rEJBM1JBXG45/c6IADWG" --=-rEJBM1JBXG45/c6IADWG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable El s=C3=A1b, 07-02-2009 a las 20:30 +0100, Felix Zielcke escribi=C3=B3: > Am Mittwoch, den 04.02.2009, 14:08 +0100 schrieb Javier Mart=C3=ADn: >=20 > > Well, I am happy to post a diff of the patch against current SVN head > > (r1973). I have personally confirmed (in a VM) that it: > > 1) Still builds (and even runs! ^^) > > 2) Works with existing ext2/3 file systems (I haven't checked ext4 FSs > > but the "extents" bit is marked as supported, so it should work) > > 3) Correctly rejects journal devices, which will then appear as "unknow= n > > filesystem" when accessed. >=20 > FLEX_BG needs to be added to the list of ignored flags. > As Robert already said in his last reply to this thread [0] >=20 > const char *local_error =3D 0; > Please use NULL. >=20 > + EXT2_DRIVER_MOUNT_FAIL(0); >=20 > I share his opinion that this isn't needed. >=20 > If you fix this and write a changelog then I commit this. >=20 > [0] http://lists.gnu.org/archive/html/grub-devel/2008-08/msg00645.html Oops... I was going to send a new version of the patch with those fixed, but when doing a "svn up" so that it would be against HEAD, I've noticed that Robert has just integrated a much cleaner version without the macro and local_error thingies. Well, the only thing left to do is adding flex_bg - here goes the patch. It also clarifies a comment and corrects those added in my original patch and Robert's cleaned-up version that don't end with ". */" as they should. -- Lazy, Oblivious, Rational Disaster -- Habbit BTW: Robert, you're having a total mailing spree today! What's it been, 30 posts? Evolution nearly choked, and my spam filter was about to ban you as "mass mailing - possible spam" ;) --=-rEJBM1JBXG45/c6IADWG Content-Disposition: attachment; filename="ext2_incompat_flexbg.patch" Content-Type: text/x-patch; name="ext2_incompat_flexbg.patch"; charset="UTF-8" Content-Transfer-Encoding: base64 SW5kZXg6IGZzL2V4dDIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIGZzL2V4dDIuYwkocmV2aXNpb24gMTk3 NykNCisrKyBmcy9leHQyLmMJKHdvcmtpbmcgY29weSkNCkBAIC03Myw3ICs3Myw3IEBADQogDQog LyogU3VwZXJibG9jayBmaWxlc3lzdGVtIGZlYXR1cmUgZmxhZ3MgKFJXIGNvbXBhdGlibGUpDQog ICogQSBmaWxlc3lzdGVtIHdpdGggYW55IG9mIHRoZXNlIGVuYWJsZWQgY2FuIGJlIHJlYWQgYW5k IHdyaXR0ZW4gYnkgYSBkcml2ZXINCi0gKiB0aGF0IGRvZXMgbm90IHVuZGVyc3RhbmQgdGhlbSB3 aXRob3V0IGNhdXNpbmcgbWV0YWRhdGEvZGF0YSBjb3JydXB0aW9uICovDQorICogdGhhdCBkb2Vz IG5vdCB1bmRlcnN0YW5kIHRoZW0gd2l0aG91dCBjYXVzaW5nIG1ldGFkYXRhL2RhdGEgY29ycnVw dGlvbi4gICovDQogI2RlZmluZSBFWFQyX0ZFQVRVUkVfQ09NUEFUX0RJUl9QUkVBTExPQwkweDAw MDENCiAjZGVmaW5lIEVYVDJfRkVBVFVSRV9DT01QQVRfSU1BR0lDX0lOT0RFUwkweDAwMDINCiAj ZGVmaW5lIEVYVDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwJCTB4MDAwNA0KQEAgLTgzLDcg KzgzLDcgQEANCiAvKiBTdXBlcmJsb2NrIGZpbGVzeXN0ZW0gZmVhdHVyZSBmbGFncyAoUk8gY29t cGF0aWJsZSkNCiAgKiBBIGZpbGVzeXN0ZW0gd2l0aCBhbnkgb2YgdGhlc2UgZW5hYmxlZCBjYW4g YmUgc2FmZWx5IHJlYWQgYnkgYSBkcml2ZXIgdGhhdA0KICAqIGRvZXMgbm90IHVuZGVyc3RhbmQg dGhlbSwgYnV0IHNob3VsZCBub3QgYmUgd3JpdHRlbiB0bywgdXN1YWxseSBiZWNhdXNlDQotICog YWRkaXRpb25hbCBtZXRhZGF0YSBpcyByZXF1aXJlZCAqLw0KKyAqIGFkZGl0aW9uYWwgbWV0YWRh dGEgaXMgcmVxdWlyZWQuICAqLw0KICNkZWZpbmUgRVhUMl9GRUFUVVJFX1JPX0NPTVBBVF9TUEFS U0VfU1VQRVIJMHgwMDAxDQogI2RlZmluZSBFWFQyX0ZFQVRVUkVfUk9fQ09NUEFUX0xBUkdFX0ZJ TEUJMHgwMDAyDQogI2RlZmluZSBFWFQyX0ZFQVRVUkVfUk9fQ09NUEFUX0JUUkVFX0RJUgkweDAw MDQNCkBAIC05Myw3ICs5Myw3IEBADQogLyogU3VwZXJibG9jayBmaWxlc3lzdGVtIGZlYXR1cmUg ZmxhZ3MgKGJhY2staW5jb21wYXRpYmxlKQ0KICAqIEEgZmlsZXN5c3RlbSB3aXRoIGFueSBvZiB0 aGVzZSBlbmFibGVkIHNob3VsZCBub3QgYmUgYXR0ZW1wdGVkIHRvIGJlIHJlYWQNCiAgKiBieSBh IGRyaXZlciB0aGF0IGRvZXMgbm90IHVuZGVyc3RhbmQgdGhlbSwgc2luY2UgdGhleSB1c3VhbGx5 IGluZGljYXRlDQotICogbWV0YWRhdGEgZm9ybWF0IGNoYW5nZXMgdGhhdCBtaWdodCBjb25mdXNl IHRoZSByZWFkZXIuICovDQorICogbWV0YWRhdGEgZm9ybWF0IGNoYW5nZXMgdGhhdCBtaWdodCBj b25mdXNlIHRoZSByZWFkZXIuICAqLw0KICNkZWZpbmUgRVhUMl9GRUFUVVJFX0lOQ09NUEFUX0NP TVBSRVNTSU9OCTB4MDAwMQ0KICNkZWZpbmUgRVhUMl9GRUFUVVJFX0lOQ09NUEFUX0ZJTEVUWVBF CQkweDAwMDINCiAjZGVmaW5lIEVYVDNfRkVBVFVSRV9JTkNPTVBBVF9SRUNPVkVSCQkweDAwMDQg LyogTmVlZHMgcmVjb3ZlcnkgKi8NCkBAIC0xMDQsMTcgKzEwNCwxNyBAQA0KICNkZWZpbmUgRVhU NF9GRUFUVVJFX0lOQ09NUEFUX0ZMRVhfQkcJCTB4MDIwMA0KIA0KIC8qIFRoZSBzZXQgb2YgYmFj ay1pbmNvbXBhdGlibGUgZmVhdHVyZXMgdGhpcyBkcml2ZXIgRE9FUyBzdXBwb3J0LiBBZGQgKE9S KQ0KLSAqIGZsYWdzIGhlcmUgYXMgdGhlIHJlbGF0ZWQgZmVhdHVyZXMgYXJlIGltcGxlbWVudGVk IGludG8gdGhlIGRyaXZlciAqLw0KKyAqIGZsYWdzIGhlcmUgYXMgdGhlIHJlbGF0ZWQgZmVhdHVy ZXMgYXJlIGltcGxlbWVudGVkIGludG8gdGhlIGRyaXZlci4gICovDQogI2RlZmluZSBFWFQyX0RS SVZFUl9TVVBQT1JURURfSU5DT01QQVQgKCBFWFQyX0ZFQVRVUkVfSU5DT01QQVRfRklMRVRZUEUg XA0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgRVhUNF9GRUFUVVJF X0lOQ09NUEFUX0VYVEVOVFMgKQ0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHwgRVhUNF9GRUFUVVJFX0lOQ09NUEFUX0VYVEVOVFMgIFwNCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB8IEVYVDRfRkVBVFVSRV9JTkNPTVBBVF9GTEVYX0JHICkN CiAvKiBMaXN0IG9mIHJhdGlvbmFsZXMgZm9yIHRoZSBpZ25vcmVkICJpbmNvbXBhdGlibGUiIGZl YXR1cmVzOg0KICAqIG5lZWRzX3JlY292ZXJ5OiBOb3QgcmVhbGx5IGJhY2staW5jb21wYXRpYmxl IC0gd2FzIGFkZGVkIGFzIHN1Y2ggdG8gZm9yYmlkDQogICogICAgICAgICAgICAgICAgIGV4dDIg ZHJpdmVycyBmcm9tIG1vdW50aW5nIGFuIGV4dDMgdm9sdW1lIHdpdGggYSBkaXJ0eQ0KICAqICAg ICAgICAgICAgICAgICBqb3VybmFsIGJlY2F1c2UgdGhleSB3aWxsIGlnbm9yZSB0aGUgam91cm5h bCwgYnV0IHRoZSBuZXh0DQogICogICAgICAgICAgICAgICAgIGV4dDMgZHJpdmVyIHRvIG1vdW50 IHRoZSB2b2x1bWUgd2lsbCBmaW5kIHRoZSBqb3VybmFsIGFuZA0KICAqICAgICAgICAgICAgICAg ICByZXBsYXkgaXQsIHBvdGVudGlhbGx5IGNvcnJ1cHRpbmcgdGhlIG1ldGFkYXRhIHdyaXR0ZW4g YnkNCi0gKiAgICAgICAgICAgICAgICAgdGhlIGV4dDIgZHJpdmVycw0KLSAqLw0KKyAqICAgICAg ICAgICAgICAgICB0aGUgZXh0MiBkcml2ZXJzLiBTYWZlIHRvIGlnbm9yZSBmb3IgdGhpcyBSTyBk cml2ZXIuICAqLw0KICNkZWZpbmUgRVhUMl9EUklWRVJfSUdOT1JFRF9JTkNPTVBBVCAoIEVYVDNf RkVBVFVSRV9JTkNPTVBBVF9SRUNPVkVSICkNCiANCiANCg== --=-rEJBM1JBXG45/c6IADWG-- --=-ltcdYiS+tuWtSU289x+a Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iQIcBAABAgAGBQJJjh8sAAoJEKSl+Fbdeo72QO4P/j/EBIOh4KeiqpH6Pc7kvlyN w8pM394VTvkoChQZJO2JHhPvOwB8btZzmEM/Gup4RfrpETc4omY9hKKCunyajEYS TzA+WyEz5buyM1f3NSAjvv/ksD23q0W3HVeGLh8PCWlPYwBZ3tjT0RvZpuhvCEjf Ah9WQvKznmWLKmlAWJqzgGbaWj4KxwczxpYqkOwbkxa444DDSUzqZs8Yqxii8L8M 68F/MSZulJE20PI0w2rxicKHUV7ETvG+zV+JncJVnFUHFxcTJW4htjZILsuapt9B +8IVQ9Fw5DyaLMY+Dgf52f6xnBU0gKyzbwsZ8WQznqUh+55nBKVOqlj38q4hzrND ZbZu+7pdLRKpXWdvI20L0ibfo1jl7iqzR73/C0jPk7jH9nQ3fnW1Ehu83aMj5oFo 7r1yArSyTh8c5rTHN2evjKTPRl3ev0Jn2/TV8t8jxcHGRnbei5i7LvrmV6jHN9ho V/HHmVs9puuM6ceR4QmZhcHWcFbVdpECJ+cyIlOj8NwJm+zUwHmZBYvIGZTB5QwC 6Xui4bdWeh5QJjCLoOowAnQEVEsxFkqdEIwTdC5JvYBzprs57uMeTgadFCqAHGfA nEnoojj7AzvzesGKgta0IZHbaOJqmDBno1ZADWIfp+Hnua9nQnIU2MkaFecnAF2B a1LuVtubkW3riGEK/QE0 =ckkl -----END PGP SIGNATURE----- --=-ltcdYiS+tuWtSU289x+a--