From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1LWXSC-0005Nj-AC for mharc-grub-devel@gnu.org; Mon, 09 Feb 2009 09:49:44 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LWXSB-0005Na-9Y for grub-devel@gnu.org; Mon, 09 Feb 2009 09:49:43 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LWXS9-0005NF-Mk for grub-devel@gnu.org; Mon, 09 Feb 2009 09:49:42 -0500 Received: from [199.232.76.173] (port=42102 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LWXS9-0005NC-Jc for grub-devel@gnu.org; Mon, 09 Feb 2009 09:49:41 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:63065) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LWXS9-0006ZJ-0L for grub-devel@gnu.org; Mon, 09 Feb 2009 09:49:41 -0500 Received: from [85.180.35.61] (e180035061.adsl.alicedsl.de [85.180.35.61]) by mrelayeu.kundenserver.de (node=mrelayeu7) with ESMTP (Nemesis) id 0ML2xA-1LWXS80mJN-0003in; Mon, 09 Feb 2009 15:49:40 +0100 From: Felix Zielcke To: The development of GRUB 2 In-Reply-To: <20090209144029.GC4841@thorin> References: <1233866360.3426.31.camel@fz.local> <20090207225222.GU6343@thorin> <1234083823.3429.3.camel@fz.local> <20090209144029.GC4841@thorin> Content-Type: text/plain Date: Mon, 09 Feb 2009 15:49:46 +0100 Message-Id: <1234190986.24013.6.camel@fz.local> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit X-Provags-ID: V01U2FsdGVkX19mP/HKG+Hrlixde8MQnrD2IGS5JupigNrRw90 PMADuIfc7dheuhE7xEqyCNpVCubwXm50fPiZpX6EV1a/yPHobc gHgiIYGAN0xqxIMbSnPU11m+mtF0zLU X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] try to avoid false positives on FAT filesystem X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Feb 2009 14:49:43 -0000 Am Montag, den 09.02.2009, 15:40 +0100 schrieb Robert Millan: > > After your other commit, is this one still needed/useful? > Well my other commit just fixes the problem probable for these Dell utiliti FAT partitions because they don't have a valid FAT16 string. It could be still useful for the people who have a broken mkfs.ext2 which doestn't zero out the first 512 bytes of the partition, but did had a real valid FAT partition. And I think it shouldn't hurt to check first for ext2 and then FAT. -- Felix Zielcke