From: Michael Ellerman <michael@ellerman.id.au>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@ozlabs.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] powerpc/cell: fix dependency in cpufreq
Date: Tue, 10 Feb 2009 12:01:32 +1100 [thread overview]
Message-ID: <1234227692.8149.58.camel@localhost> (raw)
In-Reply-To: <18282.1234226812@neuling.org>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Tue, 2009-02-10 at 11:46 +1100, Michael Neuling wrote:
> cbe_cpufreq.c uses cbe_cpufreq_has_pmi which is provided by
> cbe_cpufreq_pmi.c. Hence CBE_CPUFREQ depends on CBE_CPUFREQ_PMI.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
> ---
> I'm not 100% sure is this the right fix. Should CBE_CPUFREQ really
> depend on CBE_CPUFREQ_PMI?
No I don't think it is. Look at platforms/cell/cbe_cpufreq.h, the
intention seems to be that if PMI isn't built in then that variable is
hardcoded to 0 and we never use the pmi routines.
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-02-10 1:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-10 0:46 [PATCH] powerpc/cell: fix dependency in cpufreq Michael Neuling
2009-02-10 1:01 ` Michael Ellerman [this message]
2009-02-10 1:48 ` Michael Neuling
2009-02-10 2:01 ` Michael Neuling
2009-02-10 15:55 ` Arnd Bergmann
2009-02-10 22:27 ` Michael Neuling
2009-02-10 6:51 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234227692.8149.58.camel@localhost \
--to=michael@ellerman.id.au \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.