All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felix Zielcke <fzielcke@z-51.de>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] r1986 broke FAT detection
Date: Tue, 10 Feb 2009 10:50:44 +0100	[thread overview]
Message-ID: <1234259444.3416.8.camel@fz.local> (raw)
In-Reply-To: <1234225160.10940.25.camel@localhost>

Am Dienstag, den 10.02.2009, 01:19 +0100 schrieb Javier Martín:
> At r1985, "sudo ./grub-probe -t fs -d /dev/fd0" outputs "fat" with a
> freshly-formatted VFAT floppy in the drive. At r1986, it spits "error:
> unknown filesystem". The cause is this error, repeated three times:
> 
> if (! grub_strncmp(something, "FAT12", 5))
>   goto fail;
> 
> Strncmp does not return a boolean result (i.e. matches or doesn't), but
> an _integer_ that is supposed to establish a comparison order between
> strings. Thus, a return value of 0 is actually a match. See why I insist
> on treating semantic-ints different than semantic-bools even though the
> language does not? The correction is obvious (a patch is attached):

Thanks for your patch. Commited.

-- 
Felix Zielcke




  reply	other threads:[~2009-02-10  9:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-10  0:19 [PATCH] r1986 broke FAT detection Javier Martín
2009-02-10  9:50 ` Felix Zielcke [this message]
2009-02-10 11:44   ` Javier Martín
2009-02-21 13:13     ` Robert Millan
2009-02-22 14:08       ` Javier Martín

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234259444.3416.8.camel@fz.local \
    --to=fzielcke@z-51.de \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.