From: Jay Soffian <jaysoffian@gmail.com>
To: git@vger.kernel.org
Cc: Jay Soffian <jaysoffian@gmail.com>, gitster@pobox.com
Subject: [PATCH 1/3] builtin-remote: move duplicated cleanup code its own function
Date: Wed, 11 Feb 2009 01:01:21 -0500 [thread overview]
Message-ID: <1234332083-45147-2-git-send-email-jaysoffian@gmail.com> (raw)
In-Reply-To: <1234332083-45147-1-git-send-email-jaysoffian@gmail.com>
Moved some identical lines of code into their own function in
preparation for adding additional functionality which will use this
function as well.
Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
---
builtin-remote.c | 18 ++++++++++--------
1 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/builtin-remote.c b/builtin-remote.c
index db18bcf..00e7ca5 100644
--- a/builtin-remote.c
+++ b/builtin-remote.c
@@ -632,6 +632,14 @@ static void show_list(const char *title, struct string_list *list,
printf(" %s\n", list->items[i].string);
}
+static void free_remote_ref_states(struct ref_states *states)
+{
+ /* NEEDSWORK: free remote */
+ string_list_clear(&states->new, 0);
+ string_list_clear(&states->stale, 0);
+ string_list_clear(&states->tracked, 0);
+}
+
static int get_remote_ref_states(const char *name,
struct ref_states *states,
int query)
@@ -738,10 +746,7 @@ static int show(int argc, const char **argv)
}
}
- /* NEEDSWORK: free remote */
- string_list_clear(&states.new, 0);
- string_list_clear(&states.stale, 0);
- string_list_clear(&states.tracked, 0);
+ free_remote_ref_states(&states);
}
return result;
@@ -786,10 +791,7 @@ static int prune(int argc, const char **argv)
abbrev_ref(refname, "refs/remotes/"));
}
- /* NEEDSWORK: free remote */
- string_list_clear(&states.new, 0);
- string_list_clear(&states.stale, 0);
- string_list_clear(&states.tracked, 0);
+ free_remote_ref_states(&states);
}
return result;
--
1.6.2.rc0.187.g9fcfb
next prev parent reply other threads:[~2009-02-11 6:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 6:01 [PATCH 0/3] remote HEAD improvements Jay Soffian
2009-02-11 6:01 ` Jay Soffian [this message]
2009-02-11 6:01 ` [PATCH 2/3] builtin-remote: teach show to display remote HEAD Jay Soffian
2009-02-11 6:01 ` [PATCH 3/3] builtin-remote: add sethead verb Jay Soffian
2009-02-12 0:26 ` [PATCH 2/3] builtin-remote: teach show to display remote HEAD Jeff King
2009-02-12 1:48 ` Jay Soffian
2009-02-12 1:56 ` Jeff King
2009-02-12 20:27 ` Daniel Barkalow
2009-02-12 21:24 ` Junio C Hamano
2009-02-12 21:34 ` Daniel Barkalow
2009-02-12 21:37 ` Jay Soffian
2009-02-12 22:55 ` Daniel Barkalow
2009-02-12 0:18 ` [PATCH 1/3] builtin-remote: move duplicated cleanup code its own function Jeff King
2009-02-12 1:44 ` Jay Soffian
2009-02-12 1:50 ` Jeff King
2009-02-12 20:13 ` Daniel Barkalow
2009-02-12 0:17 ` [PATCH 0/3] remote HEAD improvements Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234332083-45147-2-git-send-email-jaysoffian@gmail.com \
--to=jaysoffian@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.