From: Harvey Harrison <harvey.harrison@gmail.com>
To: David Brownell <david-b@pacbell.net>
Cc: Greg KH <greg@kroah.com>, John Linville <linville@tuxdriver.com>,
David Miller <davem@davemloft.net>,
linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] rndis: remove private wrapper of __constant_cpu_to_le32
Date: Wed, 11 Feb 2009 14:16:13 -0800 [thread overview]
Message-ID: <1234390573.5566.13.camel@brick> (raw)
In-Reply-To: <200902111412.18233.david-b@pacbell.net>
On Wed, 2009-02-11 at 14:12 -0800, David Brownell wrote:
> On Wednesday 11 February 2009, Harvey Harrison wrote:
> > Use cpu_to_le32 directly as it handles constant folding now, replace direct
> > uses of __constant_cpu_to_{endian} as well.
> >
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
>
> Acked-by: David Brownell <dbrownell@users.sourceforge.net>
>
> ... though I'm trusting you that constant folding really *does* work
> now, as it didn't when all this code was first written. Easily enough
> seen if it doesn't: build on big-endian HW will break on all the
> "case cpu_to_le32(constant):" branches. ;)
Yes, and large parts of the kernel are already moved to using the base versions
already. I fixed the constant-folding bits during the creation/consolidation
of linux/swab.h
Harvey
next prev parent reply other threads:[~2009-02-11 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 21:56 [PATCH] rndis: remove private wrapper of __constant_cpu_to_le32 Harvey Harrison
2009-02-11 22:12 ` David Brownell
2009-02-11 22:16 ` Harvey Harrison [this message]
2009-02-15 6:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234390573.5566.13.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.