From: Harvey Harrison <harvey.harrison@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfs: replace uses of __constant_{endian}
Date: Wed, 11 Feb 2009 18:52:31 -0800 [thread overview]
Message-ID: <1234407151.5566.21.camel@brick> (raw)
In-Reply-To: <2540bee2375afb6f08eb92d19e7a1bf0.squirrel@neil.brown.name>
On Thu, 2009-02-12 at 13:50 +1100, NeilBrown wrote:
> On Thu, February 12, 2009 12:16 pm, Harvey Harrison wrote:
> > The base versions handle constant folding now, none of these headers
> > are exported to userspace, so the __ prefixed versions are not
> > necessary.
>
> I assume you compile tested this?
>
> I seem to recall that the reason we did it that way was that
> some of the error codes are used in switch statements, and
> the value for a 'case:' really has to look like a constant, not just
> happen to evaluate to one.
Yes, this requirement was explicitly built-in. See how the various
__swabXX bits are done in linux/swab.h.
Harvey
next prev parent reply other threads:[~2009-02-12 2:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 1:16 [PATCH] nfs: replace uses of __constant_{endian} Harvey Harrison
2009-02-12 2:50 ` NeilBrown
2009-02-12 2:52 ` Harvey Harrison [this message]
2009-02-12 3:15 ` NeilBrown
2009-02-12 22:17 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234407151.5566.21.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.