From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: rpm@xenomai.org
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix _PAGE_CHG_MASK
Date: Fri, 13 Feb 2009 16:46:55 +1100 [thread overview]
Message-ID: <1234504015.26036.43.camel@pasglop> (raw)
In-Reply-To: <1234493350.29851.80.camel@pasglop>
On Fri, 2009-02-13 at 13:49 +1100, Benjamin Herrenschmidt wrote:
> > diff --git a/arch/powerpc/include/asm/pgtable-ppc32.h b/arch/powerpc/include/asm/pgtable-ppc32.h
> > index 75dded6..8298afc 100644
> > --- a/arch/powerpc/include/asm/pgtable-ppc32.h
> > +++ b/arch/powerpc/include/asm/pgtable-ppc32.h
> > @@ -428,8 +428,8 @@ extern int icache_44x_need_flush;
> > #define PMD_PAGE_SIZE(pmd) bad_call_to_PMD_PAGE_SIZE()
> > #endif
> >
> > -#define _PAGE_CHG_MASK (PAGE_MASK | _PAGE_ACCESSED | _PAGE_DIRTY | _PAGE_SPECIAL)
> > -
> > +#define _PAGE_CHG_MASK (PAGE_MASK | _PAGE_ACCESSED | _PAGE_DIRTY | \
> > + _PAGE_SPECIAL)
> >
> > #define PAGE_PROT_BITS (_PAGE_GUARDED | _PAGE_COHERENT | _PAGE_NO_CACHE | \
> > _PAGE_WRITETHRU | _PAGE_ENDIAN | \
> >
BTW. That part of the patch looks bad (ie, the original line isn't what
is upstream). I've fixed up locally.
Cheers,
Ben.
next prev parent reply other threads:[~2009-02-13 5:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 22:18 [PATCH] powerpc: Fix _PAGE_CHG_MASK Philippe Gerum
2009-02-13 2:49 ` Benjamin Herrenschmidt
2009-02-13 5:46 ` Benjamin Herrenschmidt [this message]
2009-02-13 10:01 ` Philippe Gerum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234504015.26036.43.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rpm@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.