From: Zhu Yi <yi.zhu@intel.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: "linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
James Ketrenos <jketreno@linux.intel.com>,
"Chatre, Reinette" <reinette.chatre@intel.com>
Subject: Re: [PATCH 1/1] ipw2200, fix ipw io functions
Date: Fri, 13 Feb 2009 16:50:51 +0800 [thread overview]
Message-ID: <1234515051.6354.204.camel@debian> (raw)
In-Reply-To: <49952DFD.4050903@gmail.com>
On Fri, 2009-02-13 at 16:23 +0800, Jiri Slaby wrote:
> On 02/13/2009 01:49 AM, Zhu Yi wrote:
> > On Fri, 2009-02-13 at 05:29 +0800, Jiri Slaby wrote:
> >> /* alias to 8-bit direct read (low 4K of SRAM/regs), with debug
> >> wrapper */
> >> -#define ipw_read8(ipw, ofs) __ipw_read8(__FILE__, __LINE__, ipw, ofs)
> >> +#define ipw_read8(ipw, ofs) ({ \
> >> + IPW_DEBUG_IO("%s %d: read_direct8(0x%08X)\n", __FILE__, __LINE__, \
> >> + (u32)(ofs)); \
> >> + _ipw_read8(ipw, ofs); \
> >> +})
> >
> > Please put a do {} while(0) for this and some of below macros as well.
>
> This is impossible, reads need to return a value...
Right.
Acked-by: Zhu Yi <yi.zhu@intel.com>
Thanks,
-yi
next prev parent reply other threads:[~2009-02-13 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 21:29 [PATCH 1/1] ipw2200, fix ipw io functions Jiri Slaby
2009-02-13 0:49 ` Zhu Yi
2009-02-13 8:23 ` Jiri Slaby
2009-02-13 8:50 ` Zhu Yi [this message]
2009-02-13 15:44 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1234515051.6354.204.camel@debian \
--to=yi.zhu@intel.com \
--cc=jirislaby@gmail.com \
--cc=jketreno@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=reinette.chatre@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.