From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759331AbZBMNDY (ORCPT ); Fri, 13 Feb 2009 08:03:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753455AbZBMNDN (ORCPT ); Fri, 13 Feb 2009 08:03:13 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:53834 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752639AbZBMNDL (ORCPT ); Fri, 13 Feb 2009 08:03:11 -0500 Subject: Re: irq-disabled vs vmap vs text_poke From: Peter Zijlstra To: Nick Piggin Cc: akpm , Mathieu Desnoyers , linux-kernel , Ingo Molnar In-Reply-To: <1234530138.6519.38.camel@twins> References: <1234529407.6519.28.camel@twins> <20090213125505.GE18462@wotan.suse.de> <1234530138.6519.38.camel@twins> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Fri, 13 Feb 2009 14:05:11 +0100 Message-Id: <1234530311.6519.42.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2009-02-13 at 14:02 +0100, Peter Zijlstra wrote: > Agreed, I think we want to fix text_poke() and make the vmap/vunmap() > ops yell louder at violations of these rules. Something like so? --- mm/vmalloc.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 75f49d3..8516cea 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1249,6 +1249,7 @@ EXPORT_SYMBOL(vfree); void vunmap(const void *addr) { BUG_ON(in_interrupt()); + might_sleep(); __vunmap(addr, 0); } EXPORT_SYMBOL(vunmap); @@ -1268,6 +1269,8 @@ void *vmap(struct page **pages, unsigned int count, { struct vm_struct *area; + might_sleep(); + if (count > num_physpages) return NULL;