All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Wysochanski <dwysocha@redhat.com>
To: lvm-devel@redhat.com
Subject: [RFC PATCH 0/12] dm_report attribute handling and liblvm vg attributes
Date: Fri, 13 Feb 2009 08:19:33 -0500	[thread overview]
Message-ID: <1234531174.2731.129.camel@f10-node1> (raw)
In-Reply-To: <1234467041-21522-1-git-send-email-dwysocha@redhat.com>

On Thu, 2009-02-12 at 14:30 -0500, Dave Wysochanski wrote:
> The purpose of this patchset is to get feedback on one approach to handling
> attributes in liblvm.  The most important patches are:
> 1/12: Adds dm_report_output_attribute() function and related structures.
> 9/12: Updates vg_open to store vg attributes in the handle.  This allows us
> to use the report memory safely (we free it in vg_close().
> 10/12: Add lvm_vg_get_attr_list() and lvm_vg_get_attr().
> 
> What is missing in the patch is the mode (read/write) of the attribute.
> I have not thought extensively about this but one option is as follows.
> Add a 'mode' or 'is_writable' field to the dm structure, and set it to
> 'readonly' for all attributes output by dm_report_output_attribute().
> Then in vg_open(), depending on the mode and capabilities of the current
> release of liblvm code, we can gradually change various attributes to
> writeable.
> 
> This patchset should build fine but with some warnings.  Attribute code
> was exercised with test code in last patch.
> 

These patches should apply cleanly on top of the following commit:
commit 9487820c32ded20b71422e79e74732273f1c4bef
Author: Christine Caulfield <ccaulfie@redhat.com>
Date:   Wed Feb 11 10:13:20 2009 +0000

    Add a fully-functional get_cluster_name() to clvmd corosync
interface.



> --
> lvm-devel mailing list
> lvm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/lvm-devel



      parent reply	other threads:[~2009-02-13 13:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 19:30 [RFC PATCH 0/12] dm_report attribute handling and liblvm vg attributes Dave Wysochanski
2009-02-12 19:30 ` [PATCH 01/12] Add dm_report_output_attributes() API to dm_report framework Dave Wysochanski
2009-02-12 19:30   ` [PATCH 02/12] Add system_dir to create_toolcontext() Dave Wysochanski
2009-02-12 19:30     ` [PATCH 03/12] Add lvm_create, lvm_destroy, lvm_reload_config() APIs Dave Wysochanski
2009-02-12 19:30       ` [PATCH 04/12] Move vg_t, lv_t, and pv_t from metadata-exported.h into lvm2.h Dave Wysochanski
2009-02-12 19:30         ` [PATCH 05/12] Add lvm_pv_name, lvm_vg_name, and lvm_lv_name accessors Dave Wysochanski
2009-02-12 19:30           ` [PATCH 06/12] Add lvm_vg_open() Dave Wysochanski
2009-02-12 19:30             ` [PATCH 07/12] Add lvm_vg_close() Dave Wysochanski
2009-02-12 19:30               ` [PATCH 08/12] Add lvm_errno(), lvm_strerror, lvm_vg_mode Dave Wysochanski
2009-02-12 19:30                 ` [PATCH 09/12] Update lvm_vg_open() to read and store the list of vg attributes Dave Wysochanski
2009-02-12 19:30                   ` [PATCH 10/12] Add lvm_vg_get_attr_list() and lvm_vg_get_attr() Dave Wysochanski
2009-02-12 19:30                     ` [PATCH 11/12] Add lvm_vgname_from_vgid() and lvm_get_vgids() Dave Wysochanski
2009-02-12 19:30                       ` [PATCH 12/12] Add test code Dave Wysochanski
2009-02-22 23:11                 ` [PATCH 08/12] Add lvm_errno(), lvm_strerror, lvm_vg_mode Alasdair G Kergon
2009-02-22 23:39                   ` Alasdair G Kergon
2009-02-22 23:00           ` [PATCH 05/12] Add lvm_pv_name, lvm_vg_name, and lvm_lv_name accessors Alasdair G Kergon
2009-02-22 22:46         ` [PATCH 04/12] Move vg_t, lv_t, and pv_t from metadata-exported.h into lvm2.h Alasdair G Kergon
2009-02-13 13:19 ` Dave Wysochanski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234531174.2731.129.camel@f10-node1 \
    --to=dwysocha@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.