All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Constantin Baranov <baranov@mercdev.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] niu: improve ethtool support for gigabit copper cards
Date: Tue, 17 Feb 2009 13:53:57 +0000	[thread overview]
Message-ID: <1234878837.3183.4.camel@achroite> (raw)
In-Reply-To: <20090217154334.97837477.baranov@mercdev.com>

On Tue, 2009-02-17 at 15:43 +0400, Constantin Baranov wrote:
> Introduced support for link speed and duplex setting (ethtool -s),
> link advertising parameters and autonegotiation (ethtool -r):
[...]

I haven't looked closely at this, but is there anything here that can't
be handled by mii_get_settings() and other functions in the mii driver?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2009-02-17 13:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-17 11:43 [PATCH 2/2] niu: improve ethtool support for gigabit copper cards Constantin Baranov
2009-02-17 13:53 ` Ben Hutchings [this message]
2009-02-17 14:43   ` Constantin Baranov
     [not found] <20090217103852.48b110af.baranov@mercdev.com>
2009-02-19  1:53 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234878837.3183.4.camel@achroite \
    --to=bhutchings@solarflare.com \
    --cc=baranov@mercdev.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.