All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 04/11] ASoC: Clean up WM8731 bias level configuration
Date: Wed, 18 Feb 2009 12:02:26 +0000	[thread overview]
Message-ID: <1234958553-16049-4-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20090218120135.GA15414@sirena.org.uk>

The WM8731 bias level configuration function was written slightly
obscurely - streamline the code a little and refresh the comments.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/wm8731.c |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
index 816e5bf..c6db677 100644
--- a/sound/soc/codecs/wm8731.c
+++ b/sound/soc/codecs/wm8731.c
@@ -396,21 +396,19 @@ static int wm8731_set_dai_fmt(struct snd_soc_dai *codec_dai,
 static int wm8731_set_bias_level(struct snd_soc_codec *codec,
 				 enum snd_soc_bias_level level)
 {
-	u16 reg = wm8731_read_reg_cache(codec, WM8731_PWR) & 0xff7f;
+	u16 reg;
 
 	switch (level) {
 	case SND_SOC_BIAS_ON:
-		/* vref/mid, osc on, dac unmute */
-		wm8731_write(codec, WM8731_PWR, reg);
 		break;
 	case SND_SOC_BIAS_PREPARE:
 		break;
 	case SND_SOC_BIAS_STANDBY:
-		/* everything off except vref/vmid, */
+		/* Clear PWROFF, gate CLKOUT, everything else as-is */
+		reg = wm8731_read_reg_cache(codec, WM8731_PWR) & 0xff7f;
 		wm8731_write(codec, WM8731_PWR, reg | 0x0040);
 		break;
 	case SND_SOC_BIAS_OFF:
-		/* everything off, dac mute, inactive */
 		wm8731_write(codec, WM8731_ACTIVE, 0x0);
 		wm8731_write(codec, WM8731_PWR, 0xffff);
 		break;
-- 
1.5.6.3

  parent reply	other threads:[~2009-02-18 12:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-18 12:01 ASoC updates for 2.6.30 Mark Brown
2009-02-18 12:02 ` [PATCH 01/11] ASoC: Fix DaVinci module unload error Mark Brown
2009-02-18 12:02 ` [PATCH 02/11] ASoC: Fix WM8753 DAIs unregistering Mark Brown
2009-02-18 12:02 ` [PATCH 03/11] ASoC: Remove version display from the WM8731 driver Mark Brown
2009-02-18 12:02 ` Mark Brown [this message]
2009-02-18 12:02 ` [PATCH 05/11] ASoC: Improve diagnostics for AT91SAM9G20-EK probe Mark Brown
2009-02-18 12:02 ` [PATCH 06/11] ASoC: Check machine type before loading on AT91SAM9G20-EK Mark Brown
2009-02-18 12:02 ` [PATCH 07/11] ASoC: Actively manage MCLK for AT91SAM9G20-EK Mark Brown
2009-02-18 12:02 ` [PATCH 08/11] ASoC: Rename AT91SAMG20-EK for applications Mark Brown
2009-02-18 12:02 ` [PATCH 09/11] ASoC: Shuffle WM8731 SPI and I2C device registration Mark Brown
2009-02-18 12:02 ` [PATCH 10/11] ASoC: Refactor WM8731 " Mark Brown
2009-02-18 12:02 ` [PATCH 11/11] ASoC: Remove version display from the WM8753 driver Mark Brown
2009-02-18 12:18 ` ASoC updates for 2.6.30 Takashi Iwai
2009-02-18 12:22   ` Takashi Iwai
2009-02-18 12:27     ` Takashi Iwai
2009-02-18 12:37       ` Mark Brown
2009-02-18 12:44         ` Takashi Iwai
2009-02-18 12:29     ` Mark Brown
2009-02-18 12:31       ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1234958553-16049-4-git-send-email-broonie@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.