From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 2/4] ASoC: Check for errors when writing WM8731 reset register
Date: Thu, 19 Feb 2009 19:02:38 +0000 [thread overview]
Message-ID: <1235070160-10709-2-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20090219190140.GA9707@sirena.org.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
sound/soc/codecs/wm8731.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
index 4191bdb..9c9fc3b 100644
--- a/sound/soc/codecs/wm8731.c
+++ b/sound/soc/codecs/wm8731.c
@@ -574,9 +574,14 @@ static int wm8731_register(struct wm8731_priv *wm8731)
memcpy(codec->reg_cache, wm8731_reg, sizeof(wm8731_reg));
+ ret = wm8731_reset(codec);
+ if (ret < 0) {
+ dev_err(codec->dev, "Failed to issue reset\n");
+ return ret;
+ }
+
wm8731_dai.dev = codec->dev;
- wm8731_reset(codec);
wm8731_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
/* Latch the update bits */
--
1.5.6.3
next prev parent reply other threads:[~2009-02-19 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-19 19:01 ASoC updates for 2.6.30 Mark Brown
2009-02-19 19:02 ` [PATCH 1/4] ASoC: TWL4030: Add digital loopback support Mark Brown
2009-02-19 19:02 ` Mark Brown [this message]
2009-02-19 19:02 ` [PATCH 3/4] ASoC: Add device init/exit annotations to new-style Wolfson CODEC drivers Mark Brown
2009-02-19 19:02 ` [PATCH 4/4] ASoC: Disable WM8731 line bypass by default Mark Brown
2009-02-20 7:42 ` ASoC updates for 2.6.30 Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235070160-10709-2-git-send-email-broonie@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.