From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757489AbZBWUK0 (ORCPT ); Mon, 23 Feb 2009 15:10:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754828AbZBWUKL (ORCPT ); Mon, 23 Feb 2009 15:10:11 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:38764 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754629AbZBWUKK (ORCPT ); Mon, 23 Feb 2009 15:10:10 -0500 Subject: Re: [PATCH] mm: gfp_to_alloc_flags() From: Peter Zijlstra To: Mel Gorman Cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Christoph Lameter , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin In-Reply-To: <20090223181713.GS6740@csn.ul.ie> References: <1235344649-18265-1-git-send-email-mel@csn.ul.ie> <1235390103.4645.80.camel@laptop> <20090223181713.GS6740@csn.ul.ie> Content-Type: text/plain Date: Mon, 23 Feb 2009 21:09:44 +0100 Message-Id: <1235419784.4645.704.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.25.91 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-02-23 at 18:17 +0000, Mel Gorman wrote: > > > > - if (((p->flags & PF_MEMALLOC) || unlikely(test_thread_flag(TIF_MEMDIE))) > > - && !in_interrupt()) { > > - if (!(gfp_mask & __GFP_NOMEMALLOC)) { > > > > At what point was this code deleted? You moved it around a bit, but it ended up here: > > -static inline int is_allocation_high_priority(struct task_struct *p, > > - gfp_t gfp_mask) > > -{ > > - if (((p->flags & PF_MEMALLOC) || unlikely(test_thread_flag(TIF_MEMDIE))) > > - && !in_interrupt()) > > - if (!(gfp_mask & __GFP_NOMEMALLOC)) > > - return 1; > > - return 0; > > -} From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id 234286B00DF for ; Mon, 23 Feb 2009 15:09:59 -0500 (EST) Subject: Re: [PATCH] mm: gfp_to_alloc_flags() From: Peter Zijlstra In-Reply-To: <20090223181713.GS6740@csn.ul.ie> References: <1235344649-18265-1-git-send-email-mel@csn.ul.ie> <1235390103.4645.80.camel@laptop> <20090223181713.GS6740@csn.ul.ie> Content-Type: text/plain Date: Mon, 23 Feb 2009 21:09:44 +0100 Message-Id: <1235419784.4645.704.camel@laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: Linux Memory Management List , Pekka Enberg , Rik van Riel , KOSAKI Motohiro , Christoph Lameter , Johannes Weiner , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin List-ID: On Mon, 2009-02-23 at 18:17 +0000, Mel Gorman wrote: > > > > - if (((p->flags & PF_MEMALLOC) || unlikely(test_thread_flag(TIF_MEMDIE))) > > - && !in_interrupt()) { > > - if (!(gfp_mask & __GFP_NOMEMALLOC)) { > > > > At what point was this code deleted? You moved it around a bit, but it ended up here: > > -static inline int is_allocation_high_priority(struct task_struct *p, > > - gfp_t gfp_mask) > > -{ > > - if (((p->flags & PF_MEMALLOC) || unlikely(test_thread_flag(TIF_MEMDIE))) > > - && !in_interrupt()) > > - if (!(gfp_mask & __GFP_NOMEMALLOC)) > > - return 1; > > - return 0; > > -} -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org