From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH] Deny external checkpoint unless frozen Date: Mon, 23 Feb 2009 16:39:07 -0800 Message-ID: <1235435947.26788.216.camel@nimitz> References: <20090221201317.GB13532@us.ibm.com> <20090223230438.GA2590@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090223230438.GA2590-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: Containers , Sukadev Bhattiprolu , "David C. Hansen" List-Id: containers.vger.kernel.org On Mon, 2009-02-23 at 17:04 -0600, Serge E. Hallyn wrote: > Quoting Sukadev Bhattiprolu (sukadev-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org): > > > > From: Sukadev Bhattiprolu > > Date: Sat, 21 Feb 2009 11:17:07 -0800 > > Subject: [PATCH] Deny external checkpoint unless task is frozen > > > > Remove a 'FIXME' and ensure that the tasks we are checkpointing are > > frozen unless its a self-checkpoint. > > > > Signed-off-by: Sukadev Bhattiprolu > > Agreed. I personally would like to just get rid of support > for t==current, but don't expect to get anywhere with that > argument :) Along the lines of what Ingo has been asking for, do we need to expose this logic in some way? Do we need a /proc/$$/checkpointable file which says, "I'm not checkpointable because I'm not frozen"? Or, is this just a core part of the API: you have to freeze before checkpointing? As such, we'll never move to a place where we're not frozen when checkpointing, so we might as well not even track or expose it. -- Dave