All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: [PATCH 2/7] ASoC: Only unregister drivers we registered for WM8753
Date: Wed, 25 Feb 2009 10:48:17 +0000	[thread overview]
Message-ID: <1235558902-20314-2-git-send-email-broonie@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20090225104701.GA20221@rakim.wolfsonmicro.main>

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/codecs/wm8753.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
index 180ec94..93c22c4 100644
--- a/sound/soc/codecs/wm8753.c
+++ b/sound/soc/codecs/wm8753.c
@@ -1845,6 +1845,7 @@ static int wm8753_remove(struct platform_device *pdev)
 {
 	struct snd_soc_device *socdev = platform_get_drvdata(pdev);
 	struct snd_soc_codec *codec = socdev->card->codec;
+	struct wm8753_setup_data *setup = socdev->codec_data;
 
 	if (codec->control_data)
 		wm8753_set_bias_level(codec, SND_SOC_BIAS_OFF);
@@ -1852,11 +1853,14 @@ static int wm8753_remove(struct platform_device *pdev)
 	snd_soc_free_pcms(socdev);
 	snd_soc_dapm_free(socdev);
 #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
-	i2c_unregister_device(codec->control_data);
-	i2c_del_driver(&wm8753_i2c_driver);
+	if (setup->i2c_address) {
+		i2c_unregister_device(codec->control_data);
+		i2c_del_driver(&wm8753_i2c_driver);
+	}
 #endif
 #if defined(CONFIG_SPI_MASTER)
-	spi_unregister_driver(&wm8753_spi_driver);
+	if (setup->spi)
+		spi_unregister_driver(&wm8753_spi_driver);
 #endif
 	kfree(codec->private_data);
 	kfree(codec);
-- 
1.6.1.3

  parent reply	other threads:[~2009-02-25 10:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25 10:47 ASoC updates for 2.6.30 Mark Brown
2009-02-25 10:48 ` [PATCH 1/7] ASoC: Report I/O errors from WM8753 reset Mark Brown
2009-02-25 10:48 ` Mark Brown [this message]
2009-02-25 10:48 ` [PATCH 3/7] ASoC: Improve WM9713 voice DAC shutdown procedure Mark Brown
2009-02-25 10:48 ` [PATCH 4/7] ASoC: Fix Zylonite voice interface stereo configurations Mark Brown
2009-02-25 16:06   ` Daniel Mack
2009-02-25 16:22     ` Mark Brown
2009-02-25 16:41       ` Daniel Mack
2009-02-25 16:54         ` Mark Brown
2009-02-26  9:59           ` pHilipp Zabel
2009-02-26 10:03             ` Daniel Mack
2009-02-25 10:48 ` [PATCH 5/7] ASoC: Shuffle WM8753 device registration code Mark Brown
2009-02-25 10:48 ` [PATCH 6/7] ASoC: Convert WM8753 to register via normal device probe Mark Brown
2009-02-25 10:48 ` [PATCH 7/7] ASoC: Only write back non-default registers when resuming WM8753 Mark Brown
2009-02-25 10:57 ` ASoC updates for 2.6.30 Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1235558902-20314-2-git-send-email-broonie@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.