From: Lin Ming <ming.m.lin@intel.com>
To: npiggin@suse.de, Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Subject: iozone regression with 2.6.29-rc6
Date: Fri, 27 Feb 2009 17:13:59 +0800 [thread overview]
Message-ID: <1235726039.11610.243.camel@minggr> (raw)
bisect locates below commits,
commit 1cf6e7d83bf334cc5916137862c920a97aabc018
Author: Nick Piggin <npiggin@suse.de>
Date: Wed Feb 18 14:48:18 2009 -0800
mm: task dirty accounting fix
YAMAMOTO-san noticed that task_dirty_inc doesn't seem to be called properly for
cases where set_page_dirty is not used to dirty a page (eg. mark_buffer_dirty).
Additionally, there is some inconsistency about when task_dirty_inc is
called. It is used for dirty balancing, however it even gets called for
__set_page_dirty_no_writeback.
So rather than increment it in a set_page_dirty wrapper, move it down to
exactly where the dirty page accounting stats are incremented.
Cc: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
below data in parenthesis is the result after above commit reverted, for example,
-10% (+2%) means,
iozone has ~10% regression with 2.6.29-rc6 compared with 2.6.29-rc5.
and
iozone has ~2% improvement with 2.6.29-rc6-revert-1cf6e7d compared with 2.6.29-rc5.
4P dual-core HT 2P qual-core 2P qual-core HT
tulsa stockley Nehalem
--------------------------------------------------------
iozone-rewrite -10% (+2%) -8% (0%) -10% (-7%)
iozone-rand-write -50% (0%) -20% (+10%)
iozone-read -13% (0%)
iozone-write -28% (-1%)
iozone-reread -5% (-1%)
iozone-mmap-read -7% (+2%)
iozone-mmap-reread -7% (+2%)
iozone-mmap-rand-read -7% (+3%)
iozone-mmap-rand-write -5% (0%)
Lin Ming
next reply other threads:[~2009-02-27 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-27 9:13 Lin Ming [this message]
2009-02-27 9:49 ` iozone regression with 2.6.29-rc6 Peter Zijlstra
2009-02-27 11:55 ` Nick Piggin
2009-03-02 2:19 ` Lin Ming
2009-03-02 3:12 ` Wu Fengguang
2009-03-02 3:16 ` Lin Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235726039.11610.243.camel@minggr \
--to=ming.m.lin@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.