From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: [RFD] Automatic suspend Date: Sun, 01 Mar 2009 17:28:43 +1100 Message-ID: <1235888923.7388.121.camel@pasglop> References: <200902192215.18365.rjw@sisk.pl> <200902281118.14595.rjw@sisk.pl> <200902282353.39763.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= Cc: Kyle Moffett , Brian Swetland , Uli Luckas , LKML , Nigel Cunningham , pm list , Arjan van de Ven List-Id: linux-pm@vger.kernel.org T24gU2F0LCAyMDA5LTAyLTI4IGF0IDE2OjA2IC0wODAwLCBBcnZlIEhqw7hubmV2w6VnIHdyb3Rl OgoKSSdtIG5vdCB0YWtpbmcgYSBwb3NpdGlvbiBvbiB0aGUgbWVyaXQgb2YgdGhlIHdha2Vsb2Nr cyBwZXIgc2Ugbm9yCndoZXRoZXIgUmFmYWVsIGlzIHJpZ2h0IG9yIHdyb25nIGhlcmUsIEkgaGF2 ZW4ndCBsb29rZWQgYXQgdGhlIHByb2JsZW0KY2xvc2VseSBlbm91Z2guIEkganVzdCB3YW50IHRv IHJlYWN0IHRvIHRoaXM6Cgo+IFRoZSBiYXNpYyBjb25jZXB0IHdhcyBkZXZlbG9wZWQgbG9uZyBi ZWZvcmUgYW5kcm9pZCB3YXMgYSBwdWJsaWMKPiBwcm9qZWN0LgoKVGhpcyBpc24ndCBnb2luZyB0 byBicmluZyB5b3UgYW55IGdvb2Qgd2lsbC4gV2UgZG9uJ3QgY2FyZSB3aGF0IHdhcyBkb25lCmJl Zm9yZSBpdCB3YXMgYSBwdWJsaWMgcHJvamVjdC4gVGhhdCBoYXMgc3RyaWN0bHkgbm8gcmVsZXZh bmNlIHRvIGhvdyBpdApzaG91bGQgYmUgc3VibWl0dGVkIHVwc3RyZWFtLgoKSG93IGxvbmcgdGhl IGNvZGUgaGFzIGJlZW4gc2ltbWVyaW5nIGludGVybmFsbHkgdG8gY29tcGFueSBYIG9yIFkgb3IK ZXZlbiBpbiBhIHB1YmxpYyB0cmVlIGRvZXNuJ3QgbWF0dGVyLiBTb21lIHRpbWVzLCB5ZXMsIHdl IGRvIHRha2UKc29tZXRoaW5nIGFzIGEgd2hvbGUsIHdoZW4gaXQgbWFrZXMgbm8gc2Vuc2UgdG8g ZG8gb3RoZXJ3aXNlIChhIGRyaXZlciwKYSBmaWxlc3lzdGVtLCAuLi4pLiAKCkJ1dCBzb21ldGhp bmcgbGlrZSB3aGF0IHlvdSBwcm9wb3NlLCBpdCBzZWVtcywgY291bGQgZWFzaWx5IGJlIGJyb2tl bgpkb3duIGludG8gYSBiYXNpYyBjb25jZXB0LCBvbiB3aGljaCBmZWF0dXJlcyBhcmUgYWRkZWQg b25lIGFmdGVyIHRoZQpvdGhlciwgYW5kIGluIHRoaXMgY2FzZSwgaXQncyB0aGUgcmlnaHQgd2F5 IHRvIGdvLCBzaW1wbHkgYmVjYXVzZSBpdCdzCmVhc2llciB0byBhcmd1ZSBmb3IgdGhlIGJhc2lj IGNvbmNlcHQgYWxvbmUgaWYgeW91IGRvbid0IGhhdmUgdG8gaGFuZGxlCmNvbW1lbnRzIGZyb21z IHBlb3BsZSB3aG8gZG9uJ3QgYWdyZWUgd2l0aCBhc3BlY3QgQSBCIG9yIEMgb2YgdGhlIG90aGVy CmZlYXR1cmVzIGludm9sdmVkLgoKQW5kIGlmIHRoZSBiYXNpYyBjb25jZXB0IGRvZXNuJ3QgZ2V0 IGFjY2VwdGVkIGluIHRoZSBmaXJzdCBwbGFjZSwgdGhlbgp0aGUgd2hvbGUgcG9pbnQgaXMgbW9v dC4uLgoKQ2hlZXJzLApCZW4uCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtcG0gbWFpbGluZyBsaXN0CmxpbnV4LXBtQGxpc3RzLmxpbnV4LWZv dW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1wbQ== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756972AbZCAGfe (ORCPT ); Sun, 1 Mar 2009 01:35:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752222AbZCAGf1 (ORCPT ); Sun, 1 Mar 2009 01:35:27 -0500 Received: from gate.crashing.org ([63.228.1.57]:41666 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752146AbZCAGf0 (ORCPT ); Sun, 1 Mar 2009 01:35:26 -0500 Subject: Re: [RFD] Automatic suspend From: Benjamin Herrenschmidt To: Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= Cc: "Rafael J. Wysocki" , Pavel Machek , Alan Stern , "Woodruff, Richard" , Arjan van de Ven , Kyle Moffett , Oliver Neukum , pm list , LKML , Nigel Cunningham , Matthew Garrett , mark gross , Uli Luckas , Igor Stoppa , Brian Swetland , Len Brown In-Reply-To: References: <200902192215.18365.rjw@sisk.pl> <200902281118.14595.rjw@sisk.pl> <200902282353.39763.rjw@sisk.pl> Content-Type: text/plain; charset="UTF-8" Date: Sun, 01 Mar 2009 17:28:43 +1100 Message-Id: <1235888923.7388.121.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.24.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2009-02-28 at 16:06 -0800, Arve Hjønnevåg wrote: I'm not taking a position on the merit of the wakelocks per se nor whether Rafael is right or wrong here, I haven't looked at the problem closely enough. I just want to react to this: > The basic concept was developed long before android was a public > project. This isn't going to bring you any good will. We don't care what was done before it was a public project. That has strictly no relevance to how it should be submitted upstream. How long the code has been simmering internally to company X or Y or even in a public tree doesn't matter. Some times, yes, we do take something as a whole, when it makes no sense to do otherwise (a driver, a filesystem, ...). But something like what you propose, it seems, could easily be broken down into a basic concept, on which features are added one after the other, and in this case, it's the right way to go, simply because it's easier to argue for the basic concept alone if you don't have to handle comments froms people who don't agree with aspect A B or C of the other features involved. And if the basic concept doesn't get accepted in the first place, then the whole point is moot... Cheers, Ben.