From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
To: wimax@linuxwimax.org
Cc: netdev@vger.kernel.org
Subject: [PATCH] wimax/i2400m: drop support for deprecated major fw interface, add for new minor
Date: Sun, 1 Mar 2009 01:42:48 -0800 [thread overview]
Message-ID: <1235900574-15319-2-git-send-email-inaky@linux.intel.com> (raw)
In-Reply-To: <1235900574-15319-1-git-send-email-inaky@linux.intel.com>
Firmware interface version 8.x.x has long been deprecated and is no
longer supported (nor available, as it is a preproduction firmware),
so it can be safely dropped.
Add support for firmware interface v9.2.x (current is 9.1.x). Firmware
version 9.2.x is backwards compatible with 9.1.x; new features are
enabled if switches are pressed to turn them on. Forthcoming commits
to the driver will start pressing those switches when the firmware
interface supports it.
Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
---
drivers/net/wimax/i2400m/control.c | 14 +++++---------
1 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wimax/i2400m/control.c b/drivers/net/wimax/i2400m/control.c
index 15d9f51..ac8fb6d 100644
--- a/drivers/net/wimax/i2400m/control.c
+++ b/drivers/net/wimax/i2400m/control.c
@@ -942,8 +942,8 @@ error_cmd_failed:
/* Firmware interface versions we support */
enum {
I2400M_HDIv_MAJOR = 9,
- I2400M_HDIv_MAJOR_2 = 8,
I2400M_HDIv_MINOR = 1,
+ I2400M_HDIv_MINOR_2 = 2,
};
@@ -1009,18 +1009,14 @@ int i2400m_firmware_check(struct i2400m *i2400m)
minor = le16_to_cpu(l4mv->minor);
branch = le16_to_cpu(l4mv->branch);
result = -EINVAL;
- if (major != I2400M_HDIv_MAJOR
- && major != I2400M_HDIv_MAJOR_2) {
- dev_err(dev, "unsupported major fw interface version "
+ if (major != I2400M_HDIv_MAJOR) {
+ dev_err(dev, "unsupported major fw version "
"%u.%u.%u\n", major, minor, branch);
goto error_bad_major;
}
- if (major == I2400M_HDIv_MAJOR_2)
- dev_err(dev, "deprecated major fw interface version "
- "%u.%u.%u\n", major, minor, branch);
result = 0;
- if (minor != I2400M_HDIv_MINOR)
- dev_warn(dev, "untested minor fw firmware version %u.%u.%u\n",
+ if (minor < I2400M_HDIv_MINOR_2 && minor > I2400M_HDIv_MINOR)
+ dev_warn(dev, "untested minor fw version %u.%u.%u\n",
major, minor, branch);
error_bad_major:
dev_info(dev, "firmware interface version %u.%u.%u\n",
--
1.5.6.5
next prev parent reply other threads:[~2009-03-01 9:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-01 9:42 [PATCH] wimax/i2400m: add the ability to fallback to other firmware files if the default is not there Inaky Perez-Gonzalez
2009-03-01 9:42 ` Inaky Perez-Gonzalez [this message]
2009-03-01 9:42 ` [PATCH] wimax/i2400m: firmware_check() encodes the firmware version in i2400m->fw_version Inaky Perez-Gonzalez
2009-03-01 9:42 ` [PATCH] wimax/i2400m: allow control of the base-station idle mode timeout Inaky Perez-Gonzalez
2009-03-01 9:42 ` [PATCH] wimax: struct device - replace bus_id with dev_name(), dev_set_name() Inaky Perez-Gonzalez
2009-03-01 9:42 ` [PATCH] wimax/i2400m: support extended data RX protocol (no need to reallocate skbs) Inaky Perez-Gonzalez
2009-03-01 9:42 ` [PATCH] wimax: replace uses of __constant_{endian} Inaky Perez-Gonzalez
2009-03-01 9:42 ` [PATCH] wimax/i2400m: implement RX reorder support Inaky Perez-Gonzalez
2009-03-01 19:06 ` [PATCH] wimax: replace uses of __constant_{endian} Harvey Harrison
2009-03-02 0:07 ` Inaky Perez-Gonzalez
2009-03-01 9:56 ` [PATCH] WiMAX-next for 2.6.30 Inaky Perez-Gonzalez
2009-03-02 11:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1235900574-15319-2-git-send-email-inaky@linux.intel.com \
--to=inaky@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=wimax@linuxwimax.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.