From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [BUG,2.6.28,s390] Fails to boot in Hercules S/390 emulator From: John Stultz In-Reply-To: <200903100437.29280.elendil@planet.nl> References: <200903080230.10099.elendil@planet.nl> <1236654582.3792.7.camel@jstultz-laptop> <200903100437.29280.elendil@planet.nl> Content-Type: text/plain Date: Mon, 09 Mar 2009 20:38:08 -0700 Message-Id: <1236656288.3792.9.camel@jstultz-laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-Archive: List-Post: To: Frans Pop Cc: linux-s390@vger.kernel.org, Roman Zippel , Thomas Gleixner , Linux Kernel Mailing List List-ID: On Tue, 2009-03-10 at 04:37 +0100, Frans Pop wrote: > On Tuesday 10 March 2009, John Stultz wrote: > > > After reverting 5cd1c9c5cf30 and the somewhat related 6c9bacb41c10 on > > > top of 2.6.28.7, the system boots OK again [1]. > > > > Huh. No clue right off. What clocksource is in use on this system? > > $ cat /sys/devices/system/clocksource/clocksource0/current_clocksource > tod > (That's from 2.6.26.) > > > Also can you provide the output with the following patch? > > I already did something similar. Did you see my follow-up mail? No, sorry, I must have missed it. > I added: > + if (unlikely(clock->xtime_nsec < ((s64)xtime.tv_nsec << clock->shift))) > + printk("Negative result: %llu - %lld\n", > + (unsigned long long)clock->xtime_nsec, > + (long long)((s64)xtime.tv_nsec << clock->shift)); > > Which resulted in: > Negative result: 166039808000 - 166039808256 > > Would you still like me to try your patch? No no, I'll try to look again at your data in the morning. thanks -john