From: "J. Bruce Fields" <bfields@fieldses.org>
To: linux-nfs@vger.kernel.org
Subject: miscellaneous nfsd4 state changes
Date: Tue, 10 Mar 2009 20:26:48 -0400 [thread overview]
Message-ID: <1236731222-3294-1-git-send-email-bfields@fieldses.org> (raw)
I'm trying to move the callback code to asynchronous rpc calls, fix some
miscellaneous problems with the callback code, and break up the nfsv4
state lock.
But the callback changes aren't done yet, and are still just in my local
tree; and the locking fixup is still just on paper.
In the meantime, these are some smaller cleanups (and one small locking
change) done in preparation; these are queued up for 2.6.30, barring
any objections.
Beyond this, the (vague) longer-term plan:
- Make the callback rpc's asynchronous, and remove the separate
kthreads.
- Add a list of outstanding callbacks to the nfs4 client, for
two purposes:
- to allow restarting those calls after the rpc callback
client is destroyed and replaced with a new one (as
may happen in the setclientid case that changes the
callback channel); and
- to keep track of whether any callbacks are currently
taking too long (which I'm provisionally defining as
longer than lease_time/10 (or a second, if that's
larger)). When callbacks are taking too long, we
start returning cb_channel_down errors to the client's
renews, and we stop handing out delegations. Having
the full list of pending callbacks available may make
it easier to decide when to re-enable delegations
(which we should probably wait to do till *all*
pending too-slow callbacks have been replied to,
rather than just one of them).
For locking:
- Create a semaphore for each stateid, to be taken on the
seqid-mutating ops.
- Try to rely on spinlocks otherwise; I haven't figured out
quite what's required yet.
--b.
next reply other threads:[~2009-03-11 0:27 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 0:26 J. Bruce Fields [this message]
2009-03-11 0:26 ` [PATCH 01/14] nfsd4: trivial preprocess_stateid_op cleanup J. Bruce Fields
2009-03-11 0:26 ` [PATCH 02/14] nfsd4: move check_stateid_generation check J. Bruce Fields
2009-03-11 0:26 ` [PATCH 03/14] nfsd4: remove redundant "if" in nfs4_preprocess_stateid_op J. Bruce Fields
2009-03-11 0:26 ` [PATCH 04/14] nfsd4: remove unneeded local variable J. Bruce Fields
2009-03-11 0:26 ` [PATCH 05/14] nfsd4: remove some dprintk's J. Bruce Fields
2009-03-11 0:26 ` [PATCH 06/14] nfsd4: add a helper function to decide if stateid is delegation J. Bruce Fields
2009-03-11 0:26 ` [PATCH 07/14] nfsd4: separate delegreturn case from preprocess_stateid_op J. Bruce Fields
2009-03-11 0:26 ` [PATCH 08/14] nfsd4: fail when delegreturn gets a non-delegation stateid J. Bruce Fields
2009-03-11 0:26 ` [PATCH 09/14] nfsd4: remove unused CHECK_FH flag J. Bruce Fields
2009-03-11 0:26 ` [PATCH 10/14] nfsd4: rename io_during_grace_disallowed J. Bruce Fields
2009-03-11 0:26 ` [PATCH 11/14] nfsd4: put_nfs4_client does not require state lock J. Bruce Fields
2009-03-11 0:27 ` [PATCH 12/14] nfsd4: remove use of mutex for file_hashtable J. Bruce Fields
2009-03-11 0:27 ` [PATCH 13/14] nfsd4: fix do_probe_callback errors J. Bruce Fields
2009-03-11 0:27 ` [PATCH 14/14] nfsd4: move rpc_client setup to a separate function J. Bruce Fields
2009-03-12 10:59 ` Benny Halevy
2009-03-12 10:55 ` [PATCH 13/14] nfsd4: fix do_probe_callback errors Benny Halevy
2009-03-12 21:41 ` J. Bruce Fields
2009-03-11 18:52 ` [PATCH 12/14] nfsd4: remove use of mutex for file_hashtable Benny Halevy
2009-03-12 0:05 ` J. Bruce Fields
2009-03-12 10:49 ` Benny Halevy
2009-03-13 17:18 ` J. Bruce Fields
2009-03-18 20:28 ` J. Bruce Fields
2009-03-18 20:40 ` Benny Halevy
2009-03-18 21:03 ` J. Bruce Fields
2009-03-18 21:07 ` Benny Halevy
2009-03-11 1:52 ` [PATCH 08/14] nfsd4: fail when delegreturn gets a non-delegation stateid Yang Hongyang
2009-03-11 20:07 ` J. Bruce Fields
2009-03-11 18:29 ` Benny Halevy
2009-03-12 0:03 ` J. Bruce Fields
2009-03-11 1:47 ` [PATCH 07/14] nfsd4: separate delegreturn case from preprocess_stateid_op Yang Hongyang
2009-03-11 19:51 ` J. Bruce Fields
2009-03-11 1:12 ` [PATCH 03/14] nfsd4: remove redundant "if" in nfs4_preprocess_stateid_op Yang Hongyang
2009-03-11 1:23 ` J. Bruce Fields
2009-03-11 1:26 ` Yang Hongyang
2009-03-11 18:05 ` Benny Halevy
2009-03-11 19:49 ` J. Bruce Fields
2009-03-11 2:09 ` [PATCH 01/14] nfsd4: trivial preprocess_stateid_op cleanup Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1236731222-3294-1-git-send-email-bfields@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.