Re: [PATCH] Wacom Bluetooth mode-2 activation

[Marcel Holtmann <marcel@holtmann.org>]

Hi Bastien,

> Patch is necessary to make the Wacom Bluetooth driver I posted to
> linux-input work as expected. I've tested this successfully with my
> tablet[1].

this maybe sound like a nit-pick, but please add an extra empty line
between the if-statement and the ioctl.

+               write(sk, buf, sizeof(buf));
+       }
        err = ioctl_connadd(req);

The original code had one and so should have the new one with this extra
quirk.

Also can we please check at least the return value of write().

+               write(sk, buf, sizeof(buf));

Check the return value and at minimum have an error message printed.

Regards

Marcel